Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compiled plugin artifacts available #517

Closed
adaisley opened this issue Sep 17, 2021 · 8 comments
Closed

Make compiled plugin artifacts available #517

adaisley opened this issue Sep 17, 2021 · 8 comments
Labels
enhancement New Enhancement

Comments

@adaisley
Copy link

Is your feature request related to a problem? Please describe.
We're trying to build our own version of OpenSource Dashboards 1.0.0 from source with a few minor UI changes and we're encountering a bit of an issue in that trying to run /usr/share/opensearch-dashboards/bin/opensearch-dashboards-plugin --allow-root install securityDashboards gives us an error saying a valid URL was not specified.

I asked on the forums if anyone could provide the correct link to this so that we might download it and bring it into our Dockerfile, then run the install step on the .zip. According to @SearchyMcSearchFace, compiled plugin artifacts aren't yet available?

Describe the solution you'd like
Make compiled plugin artifacts available on https://artifacts.opensearch.org/downloads/kibana-plugins/

Describe alternatives you've considered
I haven't got too many alternatives here I'm afraid.

Additional context
https://discuss.opendistrocommunity.dev/t/errors-when-installing-plugins-in-opensearch-dashboards/7030

@adaisley adaisley added the enhancement New Enhancement label Sep 17, 2021
@dblock
Copy link
Member

dblock commented Sep 17, 2021

Aside of making .zips available, we have work in progress in #435 to get the OpenSearch Dashboards build working top-down in a repeatable way similarly to what we did for OpenSearch.

@peternied
Copy link
Member

[Triage] @stockholmux Do you have thoughts on how we want to distribute these artifacts independently or the distribution?

@stockholmux
Copy link
Member

@peternied totally open to ideas on this. To be clear we're talking about zips of the plugins on a per version basis?

Something like:
opensearch-knn-1.2.0.zip, opensearch-security-1.2.0.zip, etc.

The website is setup to attach n number of artifacts per version but I think they should be outside the primary get started/download page - it's still pretty niche. Additionally we'll need some documentation on how to install them (IIRC it's not in the OpenSearch docs)

@dblock
Copy link
Member

dblock commented Oct 15, 2021

A related ask is to have these and other distributions in maven, #716.

We can definitely extend our signing process to include plugin ZIPs and distribute those in the bundle with every build. Today we include the min artifact this way, just need to mirror that.

@dblock
Copy link
Member

dblock commented Oct 15, 2021

@adaisley You can now build OpenSearch Dashboards from the source using this repo.

./build.sh manifests/1.1.0/opensearch-dashboards-1.1.0.yml
./assemble.sh artifacts/manifest.yml

Do you still need those artifacts published if you're building everything from source anyway?

You could update the manifest pointing to your GitHub forks/changes and use the process as is.

@dblock
Copy link
Member

dblock commented Dec 7, 2021

Note that plugins seem to be working around this by publishing a .zip on GitHub, and are recommending to use those (e.g. opensearch-project/cross-cluster-replication#258), which isn't the same .zip that's included in the distribution with plugins. For one these aren't built in the same CI, and aren't signed.

@bbarani
Copy link
Member

bbarani commented Feb 19, 2022

@adaisley, The plugin zips are available at ci.artifacts.org/... location and the exact location can be found inside the manifest.yml file inside the OpenSearch-Dashboards distribution.

Extracted location from 1.2.0 manifest:

@bbarani
Copy link
Member

bbarani commented Mar 14, 2022

I am closing this issue as we are already publishing the compiled artifacts now. Please feel free to re-open this issue if this resolution doesn't address your issue.

@bbarani bbarani closed this as completed Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

5 participants