Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Artifact distribution naming is not consistent with OpenSearch/plugins #50

Closed
1 of 2 tasks
saratvemulapalli opened this issue Apr 23, 2021 · 10 comments
Closed
1 of 2 tasks
Labels
triaged This issue has been reviewed by the triage team

Comments

@saratvemulapalli
Copy link
Member

saratvemulapalli commented Apr 23, 2021

Describe the bug
CPU architectures are named x86_64 and aarch64 in OpenSearch, where as rest of the plugins use x64 and arm64.
Also platform for MacOS has different naming conventions, OpenSearch/Dashboards use darwin and the plugins use macos.

@saratvemulapalli saratvemulapalli self-assigned this Apr 23, 2021
@saratvemulapalli saratvemulapalli changed the title [BUG] CPU Architectures are not consistent with OpenSearch plugins [BUG] CPU Architectures naming is not consistent with OpenSearch plugins Apr 23, 2021
@saratvemulapalli
Copy link
Member Author

Merged the changes, closing.

@saratvemulapalli
Copy link
Member Author

Reopening this as we have another item to take care of.

@saratvemulapalli saratvemulapalli transferred this issue from opensearch-project/OpenSearch Jun 8, 2021
@saratvemulapalli saratvemulapalli removed their assignment Jun 8, 2021
@bbarani
Copy link
Member

bbarani commented Jun 17, 2021

@saratvemulapalli, what's the status of this issue? Can you mention that one item that requires attention?

@saratvemulapalli saratvemulapalli changed the title [BUG] CPU Architectures naming is not consistent with OpenSearch plugins [BUG] Artifact distribution naming is not consistent with OpenSearch plugins Jun 22, 2021
@saratvemulapalli saratvemulapalli changed the title [BUG] Artifact distribution naming is not consistent with OpenSearch plugins [BUG] Artifact distribution naming is not consistent with OpenSearch/plugins Jun 22, 2021
@saratvemulapalli
Copy link
Member Author

@bbarani we have taken care of the CPU architecture and it is unified across all the repositories.
For macos, the representation is different in OpenSearch/Dashboards (darwin) vs plugins (macos).

We should close down what it should be, depending on which either plugins have to change or OpenSearch/Dashboards will change.

@dblock
Copy link
Member

dblock commented Aug 23, 2021

@mch2 I think this works consistently for 1.1 bundle, doesn't it?

@mch2
Copy link
Member

mch2 commented Aug 30, 2021

@dblock Yes arm64 and x64 build are run in parallel and are tagged appropriately. MacOS is not yet set up.

@peternied peternied added the v1.2.0 OpenSearch 1.2 version label Sep 14, 2021
@peternied
Copy link
Member

peternied commented Sep 14, 2021

[Triage] This will be looked into when we do the mac release.

@peternied peternied added the triaged This issue has been reviewed by the triage team label Sep 21, 2021
@peternied peternied removed the v1.2.0 OpenSearch 1.2 version label Nov 16, 2021
@gaiksaya
Copy link
Member

[Triage] We will work on it when we start supporting macos. Closing this for now.

@saratvemulapalli
Copy link
Member Author

[Triage] We will work on it when we start supporting macos. Closing this for now.

Makes sense, but how would you track it, if the issue is closed?
Do we already have a meta issue for macos builds?

@gaiksaya
Copy link
Member

[Triage] We will work on it when we start supporting macos. Closing this for now.

Makes sense, but how would you track it, if the issue is closed? Do we already have a meta issue for macos builds?

Yes we do #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged This issue has been reviewed by the triage team
Projects
None yet
Development

No branches or pull requests

6 participants