Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] IntegTest report yml does not correctly include node information and numbers #4962

Open
peterzhuamazon opened this issue Aug 22, 2024 · 0 comments
Assignees
Labels
bug Something isn't working integtest

Comments

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Aug 22, 2024

Using CCR as example as it has 4 nodes, id-0 to id-3.
https://github.com/opensearch-project/opensearch-build/blob/2.16.0/manifests/2.16.0/opensearch-2.16.0-test.yml#L46-L57

However, as you can see in the test-report.yml in this run:
https://build.ci.opensearch.org/job/integ-test/8503/
https://ci.opensearch.org/ci/dbc/integ-test/2.16.0/10154/linux/x64/tar/test-results/8503/integ-test/test-report.yml

Only id-0 and id-1 are there while others are missing.

Mainly due to this section of hardcoding:
https://github.com/opensearch-project/opensearch-build/blob/2.16.0/src/report_workflow/test_report_runner.py#L167-L170

We need to dynamically read through folders and find the ids, instead of hardcoding in the python code.
Per the original review comment right here: #4352 (review)

Thanks.

@peterzhuamazon peterzhuamazon added bug Something isn't working integtest labels Aug 22, 2024
@github-actions github-actions bot added the untriaged Issues that have not yet been triaged label Aug 22, 2024
@peterzhuamazon peterzhuamazon added untriaged Issues that have not yet been triaged and removed untriaged Issues that have not yet been triaged labels Aug 22, 2024
@peterzhuamazon peterzhuamazon self-assigned this Aug 22, 2024
@peterzhuamazon peterzhuamazon moved this from 🆕 New to 🏗 In progress in Engineering Effectiveness Board Aug 22, 2024
@peterzhuamazon peterzhuamazon moved this from Backlog to In Progress in OpenSearch Engineering Effectiveness Aug 22, 2024
@Divyaasm Divyaasm moved this from 🏗 In progress to ⌛ On Hold in Engineering Effectiveness Board Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working integtest
Projects
Status: ⌛ On Hold
Status: In Progress
Development

No branches or pull requests

1 participant