Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Lucene snapshot from custom repository to artifacts.opensearch.org #3874

Closed
mch2 opened this issue Aug 11, 2023 · 15 comments
Closed

Move Lucene snapshot from custom repository to artifacts.opensearch.org #3874

mch2 opened this issue Aug 11, 2023 · 15 comments
Assignees
Labels
dependencies Pull requests that update a dependency file enhancement New Enhancement

Comments

@mch2
Copy link
Member

mch2 commented Aug 11, 2023

Is your feature request related to a problem? Please describe

Today OpenSearch hosts snapshot versions of Lucene at
repo.setUrl("https://d1nvenhzbhpy0q.cloudfront.net/snapshots/lucene/");. These snapshot versions are used to build/test against unreleased versions of Lucene on main & 2.x example. This extra url is a bit sloppy, confusing and requires extra management when we already have a url for artifacts. It would be great to host these instead under the https://artifacts.opensearch.org/snapshots or ci.opensearch.org umbrella.

Describe the solution you'd like

Create a repository under https://artifacts.opensearch.org/snapshots/lucene to host the snapshots. I think all that would be required here is a new path?
For context the existing repo was set up using the https://github.com/opensearch-project/data-prepper/tree/main/release/staging-resources-cdk.

The workflow pushing built snapshots is here. All that would need to change there is the bucket/role used.

Describe alternatives you've considered

Leaving as is.

Additional context

After this is created we can update the WF to push to the new bucket (or both temporarily), update RepositoriesSetupPlugin and any downstream using the old url directly.

Acceptance Criteria

Lucene Snapshots should be downloaded from ci.opensearch.org

@mch2 mch2 added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Aug 11, 2023
@nknize
Copy link
Contributor

nknize commented Aug 15, 2023

+1

@gaiksaya gaiksaya removed the untriaged Issues that have not yet been triaged label Aug 17, 2023
@gaiksaya
Copy link
Member

gaiksaya commented Aug 17, 2023

Hey!

I believe ci.opensearch.org is a better choice. We eventually want to move https://artifacts.opensearch.org/snapshots/ to ci.opensearch.org/snapshots too. Will take a look into integrating it.

Thanks!

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Oct 9, 2023

I want to mention that apart from moving the snapshot, we also need to start a campaign to make sure repos that use that snapshot will have the new url.

Ex: https://github.com/opensearch-project/ml-commons/blob/main/build.gradle#L33

@peterzhuamazon peterzhuamazon self-assigned this Oct 12, 2023
@peterzhuamazon peterzhuamazon added the dependencies Pull requests that update a dependency file label Oct 12, 2023
@peterzhuamazon peterzhuamazon moved this from Backlog to In Progress in OpenSearch Engineering Effectiveness Oct 12, 2023
@peterzhuamazon
Copy link
Member

peterzhuamazon commented Oct 12, 2023

Just talked with @mch2 on this and get the latest status.
Will start working on this task by 1st switching to the staging account (ci.opensearch.org).

Thanks.

@bbarani bbarani moved this from In Progress to Not started in OpenSearch Engineering Effectiveness Oct 18, 2023
@peternied
Copy link
Member

We've seen build & test failures [1] from the current hosting setup - 🤞 this change would improve the support and stability.

@bbarani bbarani moved this from Not started to In Progress in OpenSearch Engineering Effectiveness Nov 6, 2023
@peterzhuamazon
Copy link
Member

Start looking at the setups to add a new role for the syncing.

@peterzhuamazon
Copy link
Member

Able to connect to my own s3 bucket and also improve the github workflow more.
Next is to setup the account connection between aws and github actions, and raise PRs.

Thanks.

@peterzhuamazon
Copy link
Member

@mch2 will take care of the dependencies update once the link is available.
We are able to create roles to allow the process to happen.

@peterzhuamazon
Copy link
Member

All backend setups are completed now.
PR in OpenSearch:

@bbarani bbarani moved this from In Progress to In review in OpenSearch Engineering Effectiveness Nov 20, 2023
@peterzhuamazon
Copy link
Member

Old snapshots are synced to new bucket now.

@peterzhuamazon
Copy link
Member

With PR merged now I think @mch2 will start testing both after publishing a new snapshot.

@peterzhuamazon
Copy link
Member

@peterzhuamazon
Copy link
Member

Hi @mch2 we are closing this issue as Infra task is completed, please open another issue if you want to track changing urls.

Thanks.

peternied added a commit to peternied/OpenSearch-1 that referenced this issue Jan 3, 2024
peternied added a commit to peternied/OpenSearch-1 that referenced this issue Jan 3, 2024
peternied added a commit to peternied/opensearch-sdk that referenced this issue Jan 3, 2024
reta pushed a commit to opensearch-project/OpenSearch that referenced this issue Jan 3, 2024
* Switched to more reliable OpenSearch Lucene snapshot location

- Related opensearch-project/opensearch-build#3874

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Changelog entry

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

---------

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
peternied added a commit to peternied/OpenSearch-1 that referenced this issue Jan 3, 2024
…ation (opensearch-project#11728)

* Switched to more reliable OpenSearch Lucene snapshot location

- Related opensearch-project/opensearch-build#3874

(cherry picked from commit 16d457d)
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
kotwanikunal pushed a commit to opensearch-project/OpenSearch that referenced this issue Jan 3, 2024
…ation (#11728) (#11729)

* Switched to more reliable OpenSearch Lucene snapshot location

- Related opensearch-project/opensearch-build#3874

(cherry picked from commit 16d457d)
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
reta pushed a commit to opensearch-project/OpenSearch that referenced this issue Jan 9, 2024
* Switched to more reliable OpenSearch Lucene snapshot location

- Related opensearch-project/opensearch-build#3874

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Changelog entry

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Use required-approval@main

* Trigger on any review

Signed-off-by: Peter Nied <[email protected]>

* Snap to version v1.3

Signed-off-by: Peter Nied <[email protected]>

---------

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
opensearch-trigger-bot bot pushed a commit to opensearch-project/OpenSearch that referenced this issue Jan 9, 2024
* Switched to more reliable OpenSearch Lucene snapshot location

- Related opensearch-project/opensearch-build#3874

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Changelog entry

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Use required-approval@main

* Trigger on any review

Signed-off-by: Peter Nied <[email protected]>

* Snap to version v1.3

Signed-off-by: Peter Nied <[email protected]>

---------

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
(cherry picked from commit 3f5ec64)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit to opensearch-project/OpenSearch that referenced this issue Jan 9, 2024
* Switched to more reliable OpenSearch Lucene snapshot location

- Related opensearch-project/opensearch-build#3874




* Changelog entry




* Use required-approval@main

* Trigger on any review



* Snap to version v1.3



---------



(cherry picked from commit 3f5ec64)

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
saratvemulapalli pushed a commit to opensearch-project/opensearch-sdk-java that referenced this issue Jan 12, 2024
opensearch-trigger-bot bot pushed a commit to opensearch-project/opensearch-sdk-java that referenced this issue Jan 12, 2024
- Related opensearch-project/opensearch-build#3874
- Related opensearch-project/OpenSearch#11728

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Co-authored-by: Owais Kazi <[email protected]>
(cherry picked from commit 95f0eaf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
saratvemulapalli added a commit to opensearch-project/opensearch-sdk-java that referenced this issue Jan 12, 2024
)

- Related opensearch-project/opensearch-build#3874
- Related opensearch-project/OpenSearch#11728




(cherry picked from commit 95f0eaf)

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Owais Kazi <[email protected]>
Co-authored-by: Sarat Vemulapalli <[email protected]>
@peterzhuamazon
Copy link
Member

peterzhuamazon commented Feb 8, 2024

Hi @peternied @owaiskazi19 @mch2 :

Recently I have noticed you updated a lot of the lucene snapshots url.
However it is not artifacts.opensearch.org but ci.opensearch.org.
As I stated in this comment here:
#3874 (comment)

Would you mind correct this url in all repos affected so repos can correctly consume the changes.

Thanks!

@peternied
Copy link
Member

My Bad

image

peternied added a commit to peternied/OpenSearch-1 that referenced this issue Feb 8, 2024
Issues:
- Driver of this change opensearch-project/opensearch-build#3874 (comment)
- Previous change updated the wrong location opensearch-project#11728

Signed-off-by: Peter Nied <[email protected]>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this issue Mar 18, 2024
…ch-project#11728)

* Switched to more reliable OpenSearch Lucene snapshot location

- Related opensearch-project/opensearch-build#3874

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Changelog entry

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

---------

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this issue Mar 18, 2024
…t#11820)

* Switched to more reliable OpenSearch Lucene snapshot location

- Related opensearch-project/opensearch-build#3874

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Changelog entry

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Use required-approval@main

* Trigger on any review

Signed-off-by: Peter Nied <[email protected]>

* Snap to version v1.3

Signed-off-by: Peter Nied <[email protected]>

---------

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this issue Apr 25, 2024
…ch-project#11728)

* Switched to more reliable OpenSearch Lucene snapshot location

- Related opensearch-project/opensearch-build#3874

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Changelog entry

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

---------

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this issue Apr 25, 2024
…t#11820)

* Switched to more reliable OpenSearch Lucene snapshot location

- Related opensearch-project/opensearch-build#3874

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Changelog entry

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Use required-approval@main

* Trigger on any review

Signed-off-by: Peter Nied <[email protected]>

* Snap to version v1.3

Signed-off-by: Peter Nied <[email protected]>

---------

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New Enhancement
Projects
Development

No branches or pull requests

5 participants