From 1040501f402b55c5bd6031e1a9f8fae775a8b3fa Mon Sep 17 00:00:00 2001 From: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> Date: Tue, 23 Jul 2024 18:28:37 -0700 Subject: [PATCH] Fix release notes checker workflow (#4883) Signed-off-by: Sayali Gaikawad --- jenkins/release-workflows/release-notes-check.jenkinsfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jenkins/release-workflows/release-notes-check.jenkinsfile b/jenkins/release-workflows/release-notes-check.jenkinsfile index 84011a7f94..983abbec23 100644 --- a/jenkins/release-workflows/release-notes-check.jenkinsfile +++ b/jenkins/release-workflows/release-notes-check.jenkinsfile @@ -64,11 +64,11 @@ pipeline { currentBuild.result = 'ABORTED' error('ACTION and RELEASE_VERSION parameters cannot be empty!') } - if (ACTION == "check" && (GIT_LOG_DATE.isEmpty() || COMMENT == "ADD" || GIT_ISSUE_NUMBER.isEmpty())) { + if ((ACTION == "check" && COMMENT == "ADD") && (GIT_LOG_DATE.isEmpty() || GIT_ISSUE_NUMBER.isEmpty())) { currentBuild.result = 'ABORTED' error('GIT_LOG_DATE, COMMENT or GIT_ISSUE_NUMBER parameters cannot be empty when ACTION = check!') } - if (ACTION == "check" && (GIT_LOG_DATE.isEmpty() || COMMENT == "UPDATE" || COMMENT_UNIQUE_ID.isEmpty())) { + if ((ACTION == "check" && COMMENT == "UPDATE") && (GIT_LOG_DATE.isEmpty() || COMMENT_UNIQUE_ID.isEmpty())) { currentBuild.result = 'ABORTED' error('GIT_LOG_DATE, COMMENT or COMMENT_UNIQUE_ID parameters cannot be empty when ACTION = check!') }