Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Profiling Support during workload run #418

Open
sandeshkr419 opened this issue Nov 21, 2023 · 1 comment
Open

[Feature] Profiling Support during workload run #418

sandeshkr419 opened this issue Nov 21, 2023 · 1 comment
Labels
enhancement New feature or request Medium Priority

Comments

@sandeshkr419
Copy link

sandeshkr419 commented Nov 21, 2023

Is your feature request related to a problem? Please describe.

CPU profiling helps in essential development tasks to monitor resource usage, improve algorithm efficiency. Suggesting integrating async-profiler as part of OSB runs.

This project is a low overhead sampling profiler for Java that does not suffer from Safepoint bias problem. It features HotSpot-specific APIs to collect stack traces and to track memory allocations. The profiler works with OpenJDK, Oracle JDK and other Java runtimes based on HotSpot JVM.

Describe the solution you'd like

Since profiler is to run on a specific node only, the usage can be restricted to clusters which are hosted locally, i.e., localhost:9200. This omits the complexity to fetching node details when a search endpoint is provided instead.

As an introductory feature, the profiling can be restricted to obtain a flamegraph (.html) output.

In OSB run command, --profiling=flamegraph can be provided as argument to indicate if profiling is required.

As part of implementation, the profiler can be downloaded (if not downloaded), and the the profiler can be started with start option before starting any other cluster indexing/search activity and then stop option can be used at the end (refer async-profiler doc). The final OSB output can display the path to .html profiling output that is generated.

Additional context

This will assist developers working on improving indexing/search performance in OpenSearch.

Rally support for telemetry: https://esrally.readthedocs.io/en/stable/telemetry.html#jfr Not sure if we can leverage these as well.

Welcome suggestions!

@sandeshkr419 sandeshkr419 added the enhancement New feature or request label Nov 21, 2023
@sandeshkr419 sandeshkr419 changed the title [FEATURE] Profiling Support during workload run [Feature] Profiling Support during workload run Nov 21, 2023
@gkamat gkamat removed the untriaged label Nov 21, 2023
@gkamat
Copy link
Collaborator

gkamat commented Nov 21, 2023

This is a needed capability. The exact design should be scoped out before implementation can begin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Medium Priority
Projects
None yet
Development

No branches or pull requests

2 participants