Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Test with parameter expand_wildcards set to none does not return data #554

Closed
Jakob3xD opened this issue Sep 5, 2024 · 1 comment · Fixed by #552
Closed

[BUG] Test with parameter expand_wildcards set to none does not return data #554

Jakob3xD opened this issue Sep 5, 2024 · 1 comment · Fixed by #552
Labels
bug Something isn't working

Comments

@Jakob3xD
Copy link
Contributor

Jakob3xD commented Sep 5, 2024

What is the bug?

We have tests that set the parameter expand_wildcards: none, which makes the tests useless as the requests does not return useful content.

How can one reproduce the bug?

GET /_stats?expand_wildcards=none
{
  "_shards": {
    "total": 0,
    "successful": 0,
    "failed": 0
  },
  "_all": {
    "primaries": {},
    "total": {}
  },
  "indices": {}
}

What is the expected behavior?

Remove the combination expand_wildcards with value none so the tests return actual data.

Do you have any additional context?

Notices this while working on the Human fields MR as the test should have failed due to missing fields.

@Jakob3xD Jakob3xD added bug Something isn't working untriaged labels Sep 5, 2024
@Jakob3xD Jakob3xD changed the title [BUG] Test with parameter expand_wildcards set to none are useless [BUG] Test with parameter expand_wildcards set to none do not return data Sep 5, 2024
@Jakob3xD Jakob3xD changed the title [BUG] Test with parameter expand_wildcards set to none do not return data [BUG] Test with parameter expand_wildcards set to none does not return data Sep 5, 2024
@dblock
Copy link
Member

dblock commented Sep 5, 2024

Makes sense. To keep in mind that we do want to test the spec, not the functionality of OpenSearch. It's however good to have meaningful tests as we will use those as examples for auto-generating documentation.

@dblock dblock removed the untriaged label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants