Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] KnnQuery radial search spec inconsistency #535

Closed
alex-keeler opened this issue Aug 27, 2024 · 1 comment · Fixed by #538
Closed

[BUG] KnnQuery radial search spec inconsistency #535

alex-keeler opened this issue Aug 27, 2024 · 1 comment · Fixed by #538
Labels
bug Something isn't working

Comments

@alex-keeler
Copy link
Contributor

What is the bug?

The KnnQuery spec (located at schemas/_common.yaml#/components/schemas/KnnQuery) is inconsistent with the current implementation of the knn query, specifically in regards to radial search. It specifies a similarity parameter, whereas the implementation accepts a min_score or max_distance parameter to achieve the same end.

Do you have any additional context?

Radial search docs: https://opensearch.org/docs/latest/search-plugins/knn/radial-search-knn/
Original issue: opensearch-project/k-NN#814

@alex-keeler alex-keeler added bug Something isn't working untriaged labels Aug 27, 2024
@dblock
Copy link
Member

dblock commented Aug 27, 2024

Thanks for opening this @alex-keeler. Want to try and fix it? We have a nice test framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants