-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Specs for Search Pipeline SearchResponseProcessors #437
Comments
What caused thisThis was caused by a typo in the old search_pipeline.smithy file: list ResponseProcessorList {
member: RequestProcessor // should be ResponseProcessor
}
Note that this kind of errors will be caught by our new spec's linter that checks for unused schemas. 😃 How to fix it
|
Thanks for the instructions, @nhtruong! |
What is the bug?
Coming from opensearch-project/OpenSearch#14800 (comment)
I need to add specs/test for two new search response processors. However, non of the existing processors exist to serve as an example. A search for
rerank
has no code results. Similarly forrename_field
.It does look like these used to be part of the smithy spec. but that code has been removed.
It looks like the request processors are included in https://github.com/opensearch-project/opensearch-api-specification/blob/main/spec/schemas/search_pipeline._common.yaml but I don't see any of the response types there
Do you have any additional context?
The PRs for the two new processor types are targeted for 2.16.0 release.
I don't have the bandwidth to manually recreate all the response processors prior to 2.16.0 code freeze, and I'm hopeful automation already exists to translate them from the old Smithy specs.
The text was updated successfully, but these errors were encountered: