Fix compilation errors, change core package name in import #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
added
backport 2.x
|
For now that will fail until similar fix is done in "ml-commons" opensearch-project/ml-commons#1122 |
2 tasks
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
fix_compilation_errors_after_core_refactoring
branch
from
ce0f777 to
ab529cc
Compare
Codecov Report
@@ Coverage Diff @@
## main #219 +/- ##
=========================================
Coverage 89.55% 89.55%
Complexity 103 103
=========================================
Files 7 7
Lines 316 316
Branches 52 52
=========================================
Hits 283 283
Misses 16 16
Partials 17 17
|
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
wujunshen,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
heemin32
approved these changes
Jul 13, 2023
naveentatikonda
approved these changes
Jul 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit a9adfe0)
junqiu-lei
pushed a commit
that referenced
this pull request
Jul 31, 2023
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit a9adfe0) Co-authored-by: Martin Gaievski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix errors after this core refactoring PR
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.