Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech debt] Improve test coverage - phase 1, meet minimal required level #429

Open
martin-gaievski opened this issue Oct 10, 2023 · 1 comment
Labels
good first issue Good for newcomers Maintenance Add support for new versions of OpenSearch/Dashboards from upstream

Comments

@martin-gaievski
Copy link
Member

martin-gaievski commented Oct 10, 2023

Improve test coverage for repo, all packages should be above 80%.

Currently report is showing following packages that are below 80%:

Steps to repro:

  1. Check above links for code coverage report. Click on every class and check which lines or methods are not covered, write tests for those lines.
  2. If you write unit test and want to run it, do
./gradlew test

that will execute changes.
If you want to check how coverage changes after adding your test, you need to create a new PR with your changes, mark it as "Draft" and let CI run. Part of the CI execution is generation of new coverage report with your changes.

Some tips:

@martin-gaievski martin-gaievski added good first issue Good for newcomers Maintenance Add support for new versions of OpenSearch/Dashboards from upstream untriaged labels Oct 10, 2023
@dbwiddis
Copy link
Member

dbwiddis commented Sep 5, 2024

It would probably be helpful to post the coverage report link in the issue description :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Maintenance Add support for new versions of OpenSearch/Dashboards from upstream
Projects
None yet
Development

No branches or pull requests

3 participants