From 0400f4b289980ac0a9dc7b1c4fdf1d96fa0d2356 Mon Sep 17 00:00:00 2001 From: Martin Gaievski Date: Fri, 6 Oct 2023 10:04:24 -0700 Subject: [PATCH] Fixed review comments, added final to method params Signed-off-by: Martin Gaievski --- .../processor/NormalizationProcessorWorkflow.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/opensearch/neuralsearch/processor/NormalizationProcessorWorkflow.java b/src/main/java/org/opensearch/neuralsearch/processor/NormalizationProcessorWorkflow.java index e504eb5ef..9e0069b21 100644 --- a/src/main/java/org/opensearch/neuralsearch/processor/NormalizationProcessorWorkflow.java +++ b/src/main/java/org/opensearch/neuralsearch/processor/NormalizationProcessorWorkflow.java @@ -169,7 +169,7 @@ private void updateOriginalFetchResults( fetchSearchResult.hits(updatedSearchHits); } - private SearchHit[] getSearchHits(List docIds, FetchSearchResult fetchSearchResult) { + private SearchHit[] getSearchHits(final List docIds, final FetchSearchResult fetchSearchResult) { SearchHits searchHits = fetchSearchResult.hits(); SearchHit[] searchHitArray = searchHits.getHits(); // validate the both collections are of the same size @@ -179,7 +179,7 @@ private SearchHit[] getSearchHits(List docIds, FetchSearchResult fetchS return searchHitArray; } - private List unprocessedDocIds(List querySearchResults) { + private List unprocessedDocIds(final List querySearchResults) { List docIds = querySearchResults.isEmpty() ? List.of() : Arrays.stream(querySearchResults.get(0).topDocs().topDocs.scoreDocs)