Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add checkstyle support in repo #1591

Closed
dhrubo-os opened this issue Nov 4, 2023 · 6 comments
Closed

[FEATURE] Add checkstyle support in repo #1591

dhrubo-os opened this issue Nov 4, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dhrubo-os
Copy link
Collaborator

Is your feature request related to a problem?
Currently in repo, we don't have any checkstyle for which we lose consistency, code quality, readable. This can also help us to prevent common mistakes.

We need to enable Checkstyle in our repo for all the modules.

In addition, we should add spotless for all the modules in the repo.

@dhrubo-os dhrubo-os added enhancement New feature or request untriaged good first issue Good for newcomers and removed untriaged good first issue Good for newcomers labels Nov 4, 2023
@TrungBui59
Copy link
Contributor

@dhrubo-os can you assign me to this? I think I find a way to add spotless to the repo

@dhrubo-os
Copy link
Collaborator Author

@dhrubo-os can you assign me to this? I think I find a way to add spotless to the repo

We already have spotless for few modules. We need to add similar way for all the modules.

@TrungBui59
Copy link
Contributor

yeah I will check for other modules as well

@dhrubo-os
Copy link
Collaborator Author

@TrungBui59 this PR already completing some of your work.

@ylwu-amzn
Copy link
Collaborator

Seems commons sub-project doesn't have checkstyle?

@dhrubo-os
Copy link
Collaborator Author

Closing this issue as this is implemented in this PR: #2658

@github-project-automation github-project-automation bot moved this from In Progress to Done in ml-commons projects Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Development

No branches or pull requests

3 participants