Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Tool development for search AD result Tool #1548

Closed
ylwu-amzn opened this issue Oct 24, 2023 · 2 comments
Closed

[FEATURE] Tool development for search AD result Tool #1548

ylwu-amzn opened this issue Oct 24, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request feature

Comments

@ylwu-amzn
Copy link
Collaborator

ylwu-amzn commented Oct 24, 2023

Is your feature request related to a problem?

Agent framework (#1161 ) needs tools to extend functionality. This issue propose to add search AD result tools to it.

What solution would you like?

Build a tool in AD plugin to search AD result.

Agent framework (#1161 ) will provide a general tool framework. We can build search monitor/alerts tools with that framework.

  1. Build against the Tool interface on the agent_framework_dev branch: https://github.com/opensearch-project/ml-commons/blob/feature/agent_framework_dev/spi/src/main/java/org/opensearch/ml/common/spi/tools/Tool.java

  2. Review example tools in the Agent Framework POC commit: 1b85cff where there are 6 tools under ml-algorithms/src/main/java/org/opensearch/ml/engine/tools/. A good example is the CatIndices tool: https://github.com/opensearch-project/ml-commons/blob/feature/agent_framework_dev/ml-algorithms/src/main/java/org/opensearch/ml/engine/tools/CatIndexTool.java which shows how to use the NodeClient (IndicesAdminClient) to fetch Cluster Health statistics.

What alternatives have you considered?
N/A

Do you have any additional context?
#1161

@ohltyler
Copy link
Member

Combining this issue with search anomaly detectors tool. The current implementation will be using an exposed AD client (see here), and then instantiating it within ML commons to execute AD transport actions within ML commons plugin.

@ohltyler
Copy link
Member

Closed via opensearch-project/skills#52

@github-project-automation github-project-automation bot moved this from In Progress to Done in ml-commons projects Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
Development

No branches or pull requests

3 participants