Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improve test coverage for HuggingfaceTextEmbeddingTranslator.java #1384

Open
dhrubo-os opened this issue Sep 25, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dhrubo-os
Copy link
Collaborator

We need to improve test coverage in our repo.

This issue will target only to improve test coverage for HuggingfaceTextEmbeddingTranslator.java

From this url we can see where test coverage is missing for this class: https://app.codecov.io/gh/opensearch-project/ml-commons/blob/2.x/ml-algorithms%2Fsrc%2Fmain%2Fjava%2Forg%2Fopensearch%2Fml%2Fengine%2Falgorithms%2Ftext_embedding%2FHuggingfaceTextEmbeddingTranslator.java

@dhrubo-os dhrubo-os added enhancement New feature or request untriaged good first issue Good for newcomers and removed untriaged labels Sep 25, 2023
@kmcarranza
Copy link

kmcarranza commented Sep 27, 2023

@dhrubo-os I would like to do this as a first project.

@dhrubo-os
Copy link
Collaborator Author

Sure, assigning to you.

@dhrubo-os
Copy link
Collaborator Author

@kmcarranza any update on this?

@kmcarranza
Copy link

@dhrubo-os Hello. I still working on this code and I hope to have something to push Monday. Thank you.

@dhrubo-os
Copy link
Collaborator Author

@kmcarranza any update on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants