Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]Improve test coverage for HttpJsonConnectorExecutor.java #1381

Open
dhrubo-os opened this issue Sep 25, 2023 · 3 comments
Open

[FEATURE]Improve test coverage for HttpJsonConnectorExecutor.java #1381

dhrubo-os opened this issue Sep 25, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dhrubo-os
Copy link
Collaborator

dhrubo-os commented Sep 25, 2023

We need to improve test coverage in our repo.

This issue will target only to improve test coverage for HttpJsonConnectorExecutor.java

From this url we can see where test coverage is missing for this class: https://app.codecov.io/gh/opensearch-project/ml-commons/blob/2.x/ml-algorithms%2Fsrc%2Fmain%2Fjava%2Forg%2Fopensearch%2Fml%2Fengine%2Falgorithms%2Fremote%2FHttpJsonConnectorExecutor.java

@dhrubo-os dhrubo-os added enhancement New feature or request untriaged good first issue Good for newcomers and removed untriaged labels Sep 25, 2023
@TrungBui59
Copy link
Contributor

@dhrubo-os Can I take this issue?

@dhrubo-os
Copy link
Collaborator Author

Sure, assigned the issue to you

@TrungBui59
Copy link
Contributor

@dhrubo-os can you give some idea of some of tests needed? I am quite clueless on how many tests needed and what I should test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants