Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Increase Test Coverage for ModelAccessControlHelper.java class #1374

Open
dhrubo-os opened this issue Sep 25, 2023 · 4 comments
Open
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dhrubo-os
Copy link
Collaborator

dhrubo-os commented Sep 25, 2023

We need to improve test coverage in our repo.

This issue will target only to improve test coverage for ModelAccessControlHelper.java class

From this url we can see where test coverage is missing for this class: https://app.codecov.io/gh/opensearch-project/ml-commons/blob/2.x/plugin%2Fsrc%2Fmain%2Fjava%2Forg%2Fopensearch%2Fml%2Fhelper%2FModelAccessControlHelper.java

@dhrubo-os dhrubo-os added enhancement New feature or request good first issue Good for newcomers labels Sep 25, 2023
@th3ch3wy
Copy link

th3ch3wy commented Oct 4, 2023

Hi I would like to work on this as my first issue

@dhrubo-os
Copy link
Collaborator Author

Sure, assigned to you.

@dhrubo-os
Copy link
Collaborator Author

@th3ch3wy any update on this issue?

@th3ch3wy
Copy link

th3ch3wy commented Nov 6, 2023

@th3ch3wy any update on this issue?

Hi, so sorry I was not able to work on the issue recently, I was sick for a few weeks and catching up on school work, I am going to catch up and contribute as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants