diff --git a/.github/workflows/CI-workflow.yml b/.github/workflows/CI-workflow.yml index c8bc05d79a..da4d64c33c 100644 --- a/.github/workflows/CI-workflow.yml +++ b/.github/workflows/CI-workflow.yml @@ -23,7 +23,7 @@ jobs: needs: Get-CI-Image-Tag strategy: matrix: - java: [11, 17] + java: [11, 17, 21] name: Build and Test MLCommons Plugin on linux if: github.repository == 'opensearch-project/ml-commons' @@ -88,7 +88,7 @@ jobs: needs: Build-ml-linux strategy: matrix: - java: [11, 17, 20] + java: [11, 17, 21] name: Test MLCommons Plugin on linux docker if: github.repository == 'opensearch-project/ml-commons' @@ -173,7 +173,7 @@ jobs: Build-ml-windows: strategy: matrix: - java: [11, 17] + java: [11, 17, 21] name: Build and Test MLCommons Plugin on Windows if: github.repository == 'opensearch-project/ml-commons' environment: ml-commons-cicd-env diff --git a/build.gradle b/build.gradle index 151dfc2f6f..c2c1d9ef74 100644 --- a/build.gradle +++ b/build.gradle @@ -40,9 +40,9 @@ buildscript { } plugins { - id 'com.netflix.nebula.ospackage' version "11.1.0" + id 'com.netflix.nebula.ospackage' version "11.5.0" id 'java' - id "io.freefair.lombok" version "8.0.1" + id "io.freefair.lombok" version "8.4" id 'jacoco' } diff --git a/client/build.gradle b/client/build.gradle index 74ce5600d6..7c9c0b43ea 100644 --- a/client/build.gradle +++ b/client/build.gradle @@ -9,7 +9,7 @@ plugins { id 'jacoco' id 'com.github.johnrengelman.shadow' id 'maven-publish' - id 'com.diffplug.spotless' version '6.18.0' + id 'com.diffplug.spotless' version '6.23.0' id 'signing' } @@ -17,7 +17,7 @@ dependencies { implementation project(':opensearch-ml-common') compileOnly group: 'org.opensearch', name: 'opensearch', version: "${opensearch_version}" testImplementation group: 'junit', name: 'junit', version: '4.13.2' - testImplementation group: 'org.mockito', name: 'mockito-core', version: '4.4.0' + testImplementation group: 'org.mockito', name: 'mockito-core', version: '5.7.0' } diff --git a/common/build.gradle b/common/build.gradle index 898a5c404d..c8be258615 100644 --- a/common/build.gradle +++ b/common/build.gradle @@ -16,13 +16,17 @@ dependencies { testImplementation group: 'junit', name: 'junit', version: '4.13.2' compileOnly "org.opensearch.client:opensearch-rest-client:${opensearch_version}" compileOnly "org.opensearch:common-utils:${common_utils_version}" - testImplementation group: 'org.mockito', name: 'mockito-core', version: '4.4.0' + testImplementation group: 'org.mockito', name: 'mockito-core', version: '5.7.0' compileOnly group: 'org.apache.commons', name: 'commons-text', version: '1.10.0' compileOnly group: 'com.google.code.gson', name: 'gson', version: '2.10.1' compileOnly group: 'org.json', name: 'json', version: '20231013' } +lombok { + version = "1.18.30" +} + jacocoTestReport { reports { xml.getRequired().set(true) diff --git a/gradle/wrapper/gradle-wrapper.jar b/gradle/wrapper/gradle-wrapper.jar index c1962a79e2..7f93135c49 100644 Binary files a/gradle/wrapper/gradle-wrapper.jar and b/gradle/wrapper/gradle-wrapper.jar differ diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index 3b37661271..5b36ae43bf 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -5,7 +5,7 @@ distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-all.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists -distributionSha256Sum=5625a0ae20fe000d9225d000b36909c7a0e0e8dda61c19b12da769add847c975 +distributionSha256Sum=3e1af3ae886920c3ac87f7a91f816c0c7c436f276a6eefdb3da152100fef72ae diff --git a/gradlew b/gradlew index aeb74cbb43..1aa94a4269 100755 --- a/gradlew +++ b/gradlew @@ -83,7 +83,8 @@ done # This is normally unused # shellcheck disable=SC2034 APP_BASE_NAME=${0##*/} -APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit +# Discard cd standard output in case $CDPATH is set (https://github.com/gradle/gradle/issues/25036) +APP_HOME=$( cd "${APP_HOME:-./}" > /dev/null && pwd -P ) || exit # Use the maximum available, or set MAX_FD != -1 to use that value. MAX_FD=maximum @@ -130,10 +131,13 @@ location of your Java installation." fi else JAVACMD=java - which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. + if ! command -v java >/dev/null 2>&1 + then + die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. Please set the JAVA_HOME variable in your environment to match the location of your Java installation." + fi fi # Increase the maximum file descriptors if we can. @@ -141,7 +145,7 @@ if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then case $MAX_FD in #( max*) # In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked. - # shellcheck disable=SC3045 + # shellcheck disable=SC2039,SC3045 MAX_FD=$( ulimit -H -n ) || warn "Could not query maximum file descriptor limit" esac @@ -149,7 +153,7 @@ if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then '' | soft) :;; #( *) # In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked. - # shellcheck disable=SC3045 + # shellcheck disable=SC2039,SC3045 ulimit -n "$MAX_FD" || warn "Could not set maximum file descriptor limit to $MAX_FD" esac @@ -198,11 +202,11 @@ fi # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' -# Collect all arguments for the java command; -# * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of -# shell script including quotes and variable substitutions, so put them in -# double quotes to make sure that they get re-expanded; and -# * put everything else in single quotes, so that it's not re-expanded. +# Collect all arguments for the java command: +# * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments, +# and any embedded shellness will be escaped. +# * For example: A user cannot expect ${Hostname} to be expanded, as it is an environment variable and will be +# treated as '${Hostname}' itself on the command line. set -- \ "-Dorg.gradle.appname=$APP_BASE_NAME" \ diff --git a/memory/build.gradle b/memory/build.gradle index 826a4d8d50..83eb747c7e 100644 --- a/memory/build.gradle +++ b/memory/build.gradle @@ -20,7 +20,7 @@ plugins { id 'java' id 'jacoco' id "io.freefair.lombok" - id 'com.diffplug.spotless' version '6.18.0' + id 'com.diffplug.spotless' version '6.23.0' } dependencies { @@ -33,7 +33,7 @@ dependencies { exclude module : 'hamcrest' exclude module : 'hamcrest-core' } - testImplementation group: 'org.mockito', name: 'mockito-core', version: '4.4.0' + testImplementation group: 'org.mockito', name: 'mockito-core', version: '5.7.0' testImplementation "org.opensearch.test:framework:${opensearch_version}" testImplementation "org.opensearch.client:opensearch-rest-client:${opensearch_version}" testImplementation group: 'com.google.code.gson', name: 'gson', version: '2.10.1' diff --git a/ml-algorithms/build.gradle b/ml-algorithms/build.gradle index a1424b3ff6..d5cf9b0bfb 100644 --- a/ml-algorithms/build.gradle +++ b/ml-algorithms/build.gradle @@ -9,7 +9,7 @@ plugins { id 'java' id 'jacoco' id "io.freefair.lombok" - id 'com.diffplug.spotless' version '6.18.0' + id 'com.diffplug.spotless' version '6.23.0' } repositories { @@ -36,8 +36,7 @@ dependencies { implementation group: 'io.protostuff', name: 'protostuff-api', version: '1.8.0' implementation group: 'io.protostuff', name: 'protostuff-collectionschema', version: '1.8.0' testImplementation group: 'junit', name: 'junit', version: '4.13.2' - testImplementation group: 'org.mockito', name: 'mockito-core', version: '4.4.0' - testImplementation group: 'org.mockito', name: 'mockito-inline', version: '4.4.0' + testImplementation group: 'org.mockito', name: 'mockito-core', version: '5.7.0' implementation group: 'com.google.guava', name: 'guava', version: '32.0.1-jre' implementation group: 'com.google.code.gson', name: 'gson', version: '2.10.1' implementation platform("ai.djl:bom:0.21.0") @@ -67,6 +66,10 @@ dependencies { implementation group: 'org.json', name: 'json', version: '20231013' } +lombok { + version = "1.18.30" +} + configurations.all { resolutionStrategy.force 'com.google.protobuf:protobuf-java:3.21.9' } diff --git a/plugin/build.gradle b/plugin/build.gradle index 1e4e887546..abf33596db 100644 --- a/plugin/build.gradle +++ b/plugin/build.gradle @@ -13,7 +13,7 @@ plugins { id "io.freefair.lombok" id 'jacoco' id 'java-library' - id 'com.diffplug.spotless' version '6.18.0' + id 'com.diffplug.spotless' version '6.23.0' id 'checkstyle' } @@ -36,7 +36,7 @@ checkstyle { } lombok { - version = "1.18.28" + version = "1.18.30" } opensearchplugin { diff --git a/search-processors/build.gradle b/search-processors/build.gradle index 878f46b942..ff52eeeddb 100644 --- a/search-processors/build.gradle +++ b/search-processors/build.gradle @@ -19,7 +19,7 @@ plugins { id 'java' id 'jacoco' id "io.freefair.lombok" - id 'com.diffplug.spotless' version '6.18.0' + id 'com.diffplug.spotless' version '6.23.0' } repositories {