-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing main branch build due to backward incompatible changes added in OpenSearch core #981
Conversation
…n OpenSearch core via PR: opensearch-project/OpenSearch#8157 Signed-off-by: Navneet Verma <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #981 +/- ##
============================================
- Coverage 85.37% 85.13% -0.24%
+ Complexity 1146 1141 -5
============================================
Files 154 154
Lines 4683 4683
Branches 423 423
============================================
- Hits 3998 3987 -11
- Misses 495 504 +9
- Partials 190 192 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-981-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 98b62183c878cc0334453ebc6947cb9424991658
# Push it to GitHub
git push --set-upstream origin backport/backport-981-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Description
Fixing main branch build due to backward incompatible changes added in OpenSeach core via PR: opensearch-project/OpenSearch#8157
Issues Resolved
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.