Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Unify LuceneEngineKnnVectorQuery and NativeEngineKnnVectorQuery within KNNQuery #2316

Open
kotwanikunal opened this issue Dec 7, 2024 · 0 comments

Comments

@kotwanikunal
Copy link
Member

Is your feature request related to a problem?
Coming in from #2115 - based on the discussions in the thread, we can unify LuceneEngineKnnVectorQuery and NativeEngineKnnVectorQuery to the common KNNQuery class. Currently, the KNNQuery class acts as a factory with the variations having common code between implementations,

What solution would you like?
Reduce code duplication across classes and unified scoring across engines would be ideal.
Additional aspects covered #2115 (comment)

With #2305 - we will optimize the Lucene queries in the meanwhile to improve performance and reduce rework.
To further develop a maintainable codebase, we can add in the recommended solution on top of the changes from #2305 and #2283 and streamline vector based queries.

What alternatives have you considered?

  • N/A

Do you have any additional context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant