Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Decouple tests from source code structure/response values #110

Open
dbbaughe opened this issue Aug 2, 2021 · 2 comments
Open

[BUG] Decouple tests from source code structure/response values #110

dbbaughe opened this issue Aug 2, 2021 · 2 comments
Labels
maintenance improves code quality, but not the product testing

Comments

@dbbaughe
Copy link
Contributor

dbbaughe commented Aug 2, 2021

Describe the bug
Our tests missed this breaking change: #108
This is because the test imports the source code setting value and uses it in the test. So when the source code and test was changed it wasn't clear that the actual response of the API had changed as the tests continued passing with the new setting key value.

For these things that should not change, we should hardcode the value in the tests themselves to ensure that if someone accidentally changes the source code it is caught in the test.

@dbbaughe dbbaughe added bug Something isn't working Beta untriaged labels Aug 2, 2021
@dblock
Copy link
Member

dblock commented Aug 2, 2021

Maybe we can get something methodical that records API requests and compares outputs?

@bowenlan-amzn
Copy link
Member

Maybe this can be part of backward compatibility tests #125

@dbbaughe dbbaughe removed the Beta label Dec 3, 2021
@bowenlan-amzn bowenlan-amzn added maintenance improves code quality, but not the product and removed bug Something isn't working enhancement New request labels Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance improves code quality, but not the product testing
Projects
None yet
Development

No branches or pull requests

3 participants