Older-version snapshots and repositories are guaranteed to work with … #7275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tan3-netapp
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
Naarcha-AWS
requested changes
May 30, 2024
| @@ -449,6 +449,8 @@ We recommend ceasing write requests to a cluster before restoring from a snapsho | |||
|
|
|||
| Snapshots are only forward-compatible by one major version. If you have an old snapshot, you can sometimes restore it into an intermediate cluster, reindex all indexes, take a new snapshot, and repeat until you arrive at your desired version, but you might find it easier to just manually index your data in the new cluster. | |||
|
|
|||
| Older-version snapshots and the repositories that contain them continue to be compatible with older versions of OpenSearch. If you have a repository containing snapshots taken by an old version, you then upgrade to another version and snapshots are taken after that as well. The old snapshots can be restored to a new cluster running the same version. | |||
There was a problem hiding this comment.
Thanks for the submission @tan3-netapp, are there limitations to using older versioned snapshots in newer versions of OpenSearch? Is it restricted to major versions, for example?
There was a problem hiding this comment.
I made an update here after encountering this issue. What I updated is just a guarantee that older versioned snapshots can always be restored to a new cluster running the same version even if the snapshot repository has been modified by the newer version. (as I put it in the Question 2 in the GitHub issue mentioned above).
Anyway, I've changed my wording. Please have another look. Thanks!
Naarcha-AWS
reviewed
Jun 4, 2024
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md
Outdated
Show resolved
Hide resolved
Naarcha-AWS
reviewed
Jun 4, 2024
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md
Outdated
Show resolved
Hide resolved
Naarcha-AWS
approved these changes
Jun 4, 2024
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md
Outdated
Show resolved
Hide resolved
hdhalter
added
4 - Doc review
Naarcha-AWS
added
5 - Editorial review
natebower
reviewed
Jun 12, 2024
There was a problem hiding this comment.
@tan3-netapp @Naarcha-AWS Please see my comments/changes and let me know if you have any questions. Thanks!
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md
Outdated
Show resolved
Hide resolved
| @@ -447,7 +447,9 @@ We recommend ceasing write requests to a cluster before restoring from a snapsho | |||
| 1. A write request to the now-deleted alias creates a new index with the same name as the alias. | |||
| 1. The alias from the snapshot fails to restore due to a naming conflict with the new index. | |||
|
|
|||
| Snapshots are only forward-compatible by one major version. If you have an old snapshot, you can sometimes restore it into an intermediate cluster, reindex all indexes, take a new snapshot, and repeat until you arrive at your desired version, but you might find it easier to just manually index your data in the new cluster. | |||
| Snapshots are only forward-compatible by one major version. Snapshots taken by older OpenSearch versions can continue to be restored by the version of OpenSearch that originally took the snapshot even after a version upgrade. For example - a snapshot taken from OpenSearch 2.11.0 or lower can be used snapshot restores with 2.11.0 clusters even after upgrading to 2.12.0. | |||
There was a problem hiding this comment.
Confirm that my changes to the last sentence retain technical accuracy.
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md
Outdated
Show resolved
Hide resolved
natebower
approved these changes
Jun 12, 2024
|
@natebower I just added again the part emphasizes that 2.11 snapshots can be snapshot restored to 2.11 clusters. Please have a look again. |
natebower
reviewed
Jun 12, 2024
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md
Outdated
Show resolved
Hide resolved
Done 😄 |
|
Thanks @natebower! :) |
…older versions of OpenSearch Signed-off-by: tan3-netapp <[email protected]>
Signed-off-by: tan3-netapp <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
…hot-restore.md Signed-off-by: Naarcha-AWS <[email protected]>
…hot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: tan3-netapp <[email protected]>
…hot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: tan3-netapp <[email protected]>
…lusters to emphasize Signed-off-by: tan3-netapp <[email protected]>
…hot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: tan3-netapp <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
#7275) * Older-version snapshots and repositories are guaranteed to work with older versions of OpenSearch Signed-off-by: tan3-netapp <[email protected]> * Change the wording Signed-off-by: tan3-netapp <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Signed-off-by: Naarcha-AWS <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: tan3-netapp <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: tan3-netapp <[email protected]> * Add again the part where the 2.11 snapshots can be restored to 2.11 clusters to emphasize Signed-off-by: tan3-netapp <[email protected]> * Update _tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: tan3-netapp <[email protected]> --------- Signed-off-by: tan3-netapp <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit 5ef5170) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…older versions of OpenSearch
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.