Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spark connector settings #4577

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Add Spark connector settings #4577

merged 5 commits into from
Jul 18, 2023

Conversation

Naarcha-AWS
Copy link
Collaborator

Fixes #3454

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
_search-plugins/sql/settings.md Outdated Show resolved Hide resolved
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS requested a review from brijos July 18, 2023 17:05
@Naarcha-AWS Naarcha-AWS self-assigned this Jul 18, 2023
@Naarcha-AWS Naarcha-AWS added 3 - Tech review PR: Tech review in progress release-notes PR: Include this PR in the automated release notes v2.9.0 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Jul 18, 2023
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

_search-plugins/sql/settings.md Outdated Show resolved Hide resolved
Co-authored-by: Chris Moore <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Jul 18, 2023
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naarcha-AWS Just a few minor changes, as discussed. Thanks!

_search-plugins/sql/settings.md Outdated Show resolved Hide resolved
`spark.datasource.flint.port` | The port number for Spark. Default is `9200`.
`spark.datasource.flint.scheme` | The data scheme used in your Spark queries. Valid values are `http` and `https`.
`spark.datasource.flint.auth` | The authorization required to access the Spark data source. Valid values are `false` and `sigv4`.
`spark.datasource.flint.region` | The region in which your OpenSearch cluster is located. Only use when `auth` is set to `sigv4`. Default value is `us-west-2``.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When referring to an AWS Region, always use "AWS Region" on first appearance. Capitalized "Region" may be used for subsequent appearances.

_search-plugins/sql/settings.md Outdated Show resolved Hide resolved
_search-plugins/sql/settings.md Outdated Show resolved Hide resolved
_search-plugins/sql/settings.md Outdated Show resolved Hide resolved
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS merged commit 9b386b3 into main Jul 18, 2023
@Naarcha-AWS Naarcha-AWS deleted the spark-connector branch July 18, 2023 23:07
@prudhvigodithi prudhvigodithi added the bug Technical problem with the doc site or broken link label Oct 3, 2023
@vagimeli vagimeli mentioned this pull request Oct 23, 2023
4 tasks
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
* Add Spark connector settings

Signed-off-by: Naarcha-AWS <[email protected]>

* Add additional settings.

Signed-off-by: Naarcha-AWS <[email protected]>

* Adjust intro description.

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Chris Moore <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Chris Moore <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
vagimeli pushed a commit that referenced this pull request Dec 21, 2023
* Add Spark connector settings

Signed-off-by: Naarcha-AWS <[email protected]>

* Add additional settings.

Signed-off-by: Naarcha-AWS <[email protected]>

* Adjust intro description.

Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Chris Moore <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Chris Moore <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Editorial review PR: Editorial review in progress bug Technical problem with the doc site or broken link release-notes PR: Include this PR in the automated release notes v2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Spark Connector
5 participants