Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent merges section of Performance Tuning could be more helpful #6549

Open
1 of 4 tasks
gregschohn opened this issue Feb 29, 2024 · 3 comments
Open
1 of 4 tasks
Labels
2 - In progress Issue/PR: The issue or PR is in progress. cluster mgmt

Comments

@gregschohn
Copy link

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

I'd like to see the documentation be more precise to prevent users from making incomplete changes or creating contradictory settings values.

Tell us about your request. Provide a summary of the request and all versions that are affected.

I've seen a case where a settings are changed via

PUT /index_name/_settings
{
"index.merge.scheduler.max_merge_count" :  "1",
“index.translog.flush_threshold_size”: “1024MB”
}

results in an exception java.lang.IllegalArgumentException: maxThreadCount (= 4) should be <= maxMergeCount (= 1). However, the documentation for concurrent-merges states that "Merges run in separate threads, and when the maximum number of threads is reached, further merges will wait until a merge thread becomes available."

If that's the case, I don't see why maxThreadCount and maxMergeCount would be related. This section could be more clear to indicate how settings affect each other

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

There's another ticket here that allowed settings to be entered without being fully validated. The exact failure behavior of these invalid settings therefore may be manifested differently.

@hdhalter
Copy link
Contributor

hdhalter commented Mar 1, 2024

@praveensameneni - Do you know who might be able to help with clarifying this in the documentation?

@hdhalter
Copy link
Contributor

hdhalter commented Mar 1, 2024

Hi @andrross , @sohami, can you please comment or help clarify this in the documentation? Thanks!

@andrross
Copy link
Member

andrross commented Mar 5, 2024

maxThreadCount (= 4) should be <= maxMergeCount (= 1)

@gregschohn I think this means that if your max thread count was larger than max merge count then you would always have idle threads because max merge count would prevent them from being used. How do you suggest we clarify this?

@hdhalter hdhalter added the 2 - In progress Issue/PR: The issue or PR is in progress. label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In progress Issue/PR: The issue or PR is in progress. cluster mgmt
Projects
None yet
Development

No branches or pull requests

3 participants