Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Torch config link for all-MiniLM-L12-v2 model incorrectly points to ONNX config #6226

Closed
1 of 4 tasks
ArranDengate-Netapp opened this issue Jan 19, 2024 · 1 comment · Fixed by #6227
Closed
1 of 4 tasks
Assignees
Labels
2 - In progress Issue/PR: The issue or PR is in progress. Machine Learning

Comments

@ArranDengate-Netapp
Copy link
Contributor

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request.

In the pretrained model page , each model has a link to Torch config and a link to ONNX config (in the TorchScript artifact and ONNX artifact columns of the table, respectively). The link to Torch config for the all-MiniLM-L12-v2 model is incorrect; it points to ONNX config (so for this model, rather than one config_url link to Torch and one to ONNX, both links point to ONNX). This appears to be the only model in the page with this issue, all other Torch config links point to Torch config.

If this ONNX config is used with the Torch model, the following error occurs in OpenSearch logs when deploying the model:

[ERROR][o.o.m.e.a.DLModel`        ] [ip-172-31-62-254.ec2.internal] Failed to deploy model smYvF40BgFhXOXZgGEgm
java.lang.NoClassDefFoundError: Could not initialize class ai.djl.onnxruntime.engine.OrtNDManager 

The incorrect link is:

https://artifacts.opensearch.org/models/ml-models/huggingface/sentence-transformers/all-MiniLM-L12-v2/1.0.1/onnx/config.json

The correct link can be determined from context. The link to Torch config for this model should instead be:

https://artifacts.opensearch.org/models/ml-models/huggingface/sentence-transformers/all-MiniLM-L12-v2/1.0.1/torch_script/config.json

This file exists, and appears to be correct - I was able to deploy the model using it.

I will submit a PR with the change shortly.

@hdhalter
Copy link
Contributor

Thanks, @ArranDengate-Netapp !

@hdhalter hdhalter added 2 - In progress Issue/PR: The issue or PR is in progress. Machine Learning and removed untriaged labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In progress Issue/PR: The issue or PR is in progress. Machine Learning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants