Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update the k-NN documentation to reflect the new Default values for K-NN engine hyper parameters #6021

Closed
1 of 4 tasks
navneet1v opened this issue Dec 29, 2023 · 1 comment · Fixed by #6272
Closed
1 of 4 tasks
Assignees
Labels
3 - Done Issue is done/complete v2.12.0
Milestone

Comments

@navneet1v
Copy link
Contributor

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
With the changes merged for this GH issue: opensearch-project/k-NN#1354, we have updated the default values for the hyper parameters for K-NN engines(faiss, Lucene, Nmslib).

The changes are BWC, means that all the new indices that will be created will have the newer values and all the old indices will still reflect use the old values of the hyper parameters.

New Values

Parameters Default Value
M 16
ef_construction 100
ef_search 100

Old Values

Parameters Default Value
M 16
ef_construction 512
ef_search 512

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

@navneet1v
Copy link
Contributor Author

PR raised. #6272

@hdhalter hdhalter added 2 - In progress Issue/PR: The issue or PR is in progress. 3 - Done Issue is done/complete and removed 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. 2 - In progress Issue/PR: The issue or PR is in progress. labels Jan 29, 2024
@hdhalter hdhalter closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete v2.12.0
Projects
None yet
2 participants