Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] update the documentation to reflect the deprecated RestTransportClient #5772

Open
3 tasks
Simon-Berhane-Paidy opened this issue Dec 4, 2023 · 6 comments
Labels
clients Documentation related to Clients

Comments

@Simon-Berhane-Paidy
Copy link

What do you want to do?
Hi there,

I learned from this page that the high level rest client is deprecated.
https://opensearch.org/docs/latest/clients/java-rest-high-level/

Then, I navigated to the java client documentation and was reviewing the options.
https://opensearch.org/docs/latest/clients/java/

One of the options says to use the Rest Client, without any deprecation notice. https://opensearch.org/docs/latest/clients/java/#installing-the-client-using-restclient-transport

So it made me think it's a different package that won't be deprecated. But looking at the source, I noticed this deprecation annotation.
https://github.com/opensearch-project/opensearch-java/blob/261cab4cf79e176b0892cfb44fad7c8cfaf44204/java-client/src/main/java/org/opensearch/client/transport/rest_client/RestClientTransport.java#L75

Am I correct then in assuming this will also be deprecated?
If so, I think mentioning this in the java client page would be very helpful.

Thanks!

  • [ ✅ ] Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request and all versions that are affected.

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

@hdhalter
Copy link
Contributor

hdhalter commented Dec 4, 2023

@VachaShah - Hi Vacha, can you please take a look at this and provide some guidance? Thanks!

@hdhalter
Copy link
Contributor

hdhalter commented Dec 6, 2023

Hi @wbeckler - Can someone on your team respond to this in Vacha's absence? Thanks!

@hdhalter hdhalter added the clients Documentation related to Clients label Dec 6, 2023
@wbeckler wbeckler removed the untriaged label Dec 6, 2023
@Xtansia
Copy link

Xtansia commented Dec 6, 2023

In the current 2.x line of the Java client, the RestClientTransport is not yet deprecated. It will however be deprecated in a future 3.0.0 release, with eventual complete removal at a later date. As such it would be incorrect to declare it as deprecated in the documentation currently, but we could definitely make it clear the ApacheHttpClient5TransportBuilder is the preferred option and potentially telegraph RestClientTransport being slated for deprecation.

@hdhalter
Copy link
Contributor

hdhalter commented Dec 7, 2023

Thanks or the clarification, @Xtansia ! Can you please add the appropriate text to the file and create a PR? We'll then review it and get it published. Thanks.

@wbeckler
Copy link
Contributor

wbeckler commented Dec 7, 2023

I feel like that extended deprecation plan might be overly conservative. Where is it stated?

@Xtansia
Copy link

Xtansia commented Dec 7, 2023

@wbeckler The main issue about the RestClientTransport deprecation specifically is this one: opensearch-project/opensearch-java#326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clients Documentation related to Clients
Projects
None yet
Development

No branches or pull requests

4 participants