From 12151b7adf44dbec06b36c63695c0e9ff3ad276f Mon Sep 17 00:00:00 2001 From: Matt Provost Date: Tue, 22 Aug 2023 19:07:58 +0000 Subject: [PATCH 1/3] Onboard Stylelint Signed-off-by: Matt Provost --- .github/workflows/test-and-build-workflow.yml | 15 +++++++++++++++ gantt-chart/package.json | 1 + 2 files changed, 16 insertions(+) diff --git a/.github/workflows/test-and-build-workflow.yml b/.github/workflows/test-and-build-workflow.yml index 595101c..87b6f92 100644 --- a/.github/workflows/test-and-build-workflow.yml +++ b/.github/workflows/test-and-build-workflow.yml @@ -51,6 +51,11 @@ jobs: cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart yarn osd bootstrap + - name: Run Stylelint + run: | + cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart + yarn lint:style + - name: Test run: | cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart @@ -117,6 +122,11 @@ jobs: cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart yarn osd bootstrap + - name: Run Stylelint + run: | + cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart + yarn lint:style + - name: Test run: | cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart @@ -175,6 +185,11 @@ jobs: cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart yarn osd bootstrap + - name: Run Stylelint + run: | + cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart + yarn lint:style + - name: Test run: | cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart diff --git a/gantt-chart/package.json b/gantt-chart/package.json index ef865f4..c911a4b 100644 --- a/gantt-chart/package.json +++ b/gantt-chart/package.json @@ -6,6 +6,7 @@ "osd": "node ../../scripts/osd", "opensearch": "node ../../scripts/opensearch", "lint": "eslint .", + "lint:style": "node ../../scripts/stylelint", "build": "yarn plugin-helpers build", "plugin-helpers": "node ../../scripts/plugin_helpers", "test": "../../node_modules/.bin/jest --config ./test/jest.config.js", From e066ae5ae10ace0320f9315c512b765f5e7c4756 Mon Sep 17 00:00:00 2001 From: Matt Provost Date: Tue, 22 Aug 2023 19:16:08 +0000 Subject: [PATCH 2/3] Fix stylelint quote error Signed-off-by: Matt Provost --- gantt-chart/public/index.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gantt-chart/public/index.scss b/gantt-chart/public/index.scss index 8b1e0cd..f92f361 100644 --- a/gantt-chart/public/index.scss +++ b/gantt-chart/public/index.scss @@ -3,7 +3,7 @@ * SPDX-License-Identifier: Apache-2.0 */ -.embPanel__content[data-loading][data-type=plotlyGanttChart] { +.embPanel__content[data-loading][data-type="plotlyGanttChart"] { pointer-events: auto; filter: none; } From a7ec2b8cdb49f4590212b20699561f43cb7c7af8 Mon Sep 17 00:00:00 2001 From: Derek Ho Date: Wed, 18 Oct 2023 12:05:48 -0400 Subject: [PATCH 3/3] Update snapshot Signed-off-by: Derek Ho --- .../__snapshots__/options_editor.test.tsx.snap | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gantt-chart/public/components/__tests__/__snapshots__/options_editor.test.tsx.snap b/gantt-chart/public/components/__tests__/__snapshots__/options_editor.test.tsx.snap index e1c8cd5..8356fa7 100644 --- a/gantt-chart/public/components/__tests__/__snapshots__/options_editor.test.tsx.snap +++ b/gantt-chart/public/components/__tests__/__snapshots__/options_editor.test.tsx.snap @@ -299,7 +299,7 @@ exports[` spec renders the component with different options 1`] xmlns="http://www.w3.org/2000/svg" > @@ -348,7 +348,7 @@ exports[` spec renders the component with different options 1`] xmlns="http://www.w3.org/2000/svg" > spec renders the component with different options 1`] xmlns="http://www.w3.org/2000/svg" > @@ -417,7 +417,7 @@ exports[` spec renders the component with different options 1`] xmlns="http://www.w3.org/2000/svg" > spec renders the component with different options 1`] xmlns="http://www.w3.org/2000/svg" >