Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add id_expression to S3 integration MVs #1266

Closed
Swiddis opened this issue Nov 22, 2023 · 1 comment
Closed

[FEATURE] Add id_expression to S3 integration MVs #1266

Swiddis opened this issue Nov 22, 2023 · 1 comment
Assignees
@RyanL1997
Labels
enhancement New feature or request good first issue Good for newcomers integrations Used to denote items related to the Integrations project

Comments

@Swiddis
Copy link
Collaborator

Swiddis commented Nov 22, 2023

Is your feature request related to a problem?
There's an incoming feature from opensearch-spark that will make including an id_expression mandatory for new materialized views. We don't have this currently, which will make future versions break if the issue isn't fixed.

What solution would you like?
Add an id_expression to each MV in integrations. It's likely that uuid() is sufficient, since the primary use case is log data where duplicates may occur.

What alternatives have you considered?
Timestamps were considered as an ID field as well, but it's well known that even precise timestamps are not unique. For some integrations it may be possible to identify a log entry ID already, but I'm not sure if this is available for any of the current ones.

Do you have any additional context?
Necessary to unblock opensearch-project/opensearch-spark#143.
@Swiddis Swiddis added enhancement New feature or request untriaged integrations Used to denote items related to the Integrations project good first issue Good for newcomers labels Nov 22, 2023
@Swiddis Swiddis removed the untriaged label Nov 30, 2023
@Swiddis Swiddis assigned Swiddis and RyanL1997 and unassigned Swiddis Dec 6, 2023
@Swiddis
Copy link
Collaborator Author

Swiddis commented Jan 16, 2024

Closing as upstream PR seems to be canceled.

@Swiddis Swiddis closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2024
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this issue Apr 18, 2024
@opensearch-trigger-bot
Add release notes for 2.4.1.0 (opensearch-project#1262) (opensearch-p…
e9d4c75 
…roject#1266)

Signed-off-by: Craig Perkins <[email protected]>
Co-authored-by: Peter Nied <[email protected]>
(cherry picked from commit 4cb6252090696b81fcd9410b74a830479fabbebb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanL1997 RyanL1997

Labels
enhancement New feature or request good first issue Good for newcomers integrations Used to denote items related to the Integrations project
Projects
Observability 2023
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Swiddis @RyanL1997