Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit and Finish UX Fixes #263

Merged
merged 15 commits into from
Sep 17, 2024
Merged

Conversation

jowg-amazon
Copy link
Contributor

Description

Addresses the fit and finish UX changes. Changes in this PR include:

  • Fills the send test message button in the View Channel page
  • Fixes the spacing across the data source to actions buttons in the View Channel page
  • Makes all content sections run full width of page
  • Removes extra 10px padding in Channels and Email recipient groups page
  • Removes bottom border across pages when empty prompt
  • Fixes the content to header spacing (16px)
  • Fixes active indicator alignment in the View Channel page
  • Fixes the section headers so it's wrapped in OuiTitle with size = s
  • Fixes spacing for actions across elements from search bar (8px)

Empty Channels Page
Screenshot 2024-09-16 at 8 40 17 PM

Channels Page
Screenshot 2024-09-16 at 8 40 58 PM

Edit Channel Page
Screenshot 2024-09-16 at 8 42 59 PM

Email Senders Page
Screenshot 2024-09-16 at 8 41 11 PM

Create SMTP Sender Page
Screenshot 2024-09-16 at 8 41 25 PM

Create SES Sender Page
Screenshot 2024-09-16 at 8 41 54 PM

Email Recipient Group Page
Screenshot 2024-09-16 at 8 42 08 PM

Edit Recipient Group Page
Screenshot 2024-09-16 at 8 42 37 PM

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joanne Wang <[email protected]>
@amsiglan amsiglan merged commit 7dd95ec into opensearch-project:main Sep 17, 2024
10 of 11 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-263-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7dd95ec17bebb0597e67afa059bd6d4161b83e2a
# Push it to GitHub
git push --set-upstream origin backport/backport-263-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-263-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.17
# Create a new branch
git switch --create backport/backport-263-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7dd95ec17bebb0597e67afa059bd6d4161b83e2a
# Push it to GitHub
git push --set-upstream origin backport/backport-263-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-263-to-2.17.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 17, 2024
* fill send test message button

Signed-off-by: Joanne Wang <[email protected]>

* extend content to full width of page

Signed-off-by: Joanne Wang <[email protected]>

* fix spacing across buttons (8px)

Signed-off-by: Joanne Wang <[email protected]>

* add vertical spacing

Signed-off-by: Joanne Wang <[email protected]>

* fix header and content 16px

Signed-off-by: Joanne Wang <[email protected]>

* remove extra 10px padding

Signed-off-by: Joanne Wang <[email protected]>

* align active indicator

Signed-off-by: Joanne Wang <[email protected]>

* wrap h2 in Eui Title with size s prop

Signed-off-by: Joanne Wang <[email protected]>

* fix padding for elements from search bar 8px

Signed-off-by: Joanne Wang <[email protected]>

* remove bottom border in empty state

Signed-off-by: Joanne Wang <[email protected]>

* wip

Signed-off-by: Joanne Wang <[email protected]>

* fix original view monitors page

Signed-off-by: Joanne Wang <[email protected]>

* fix original spacing

Signed-off-by: Joanne Wang <[email protected]>

* run yarn test:jest -u

Signed-off-by: Joanne Wang <[email protected]>

* upgrade to v4

Signed-off-by: Joanne Wang <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit 7dd95ec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Sep 17, 2024
* fill send test message button



* extend content to full width of page



* fix spacing across buttons (8px)



* add vertical spacing



* fix header and content 16px



* remove extra 10px padding



* align active indicator



* wrap h2 in Eui Title with size s prop



* fix padding for elements from search bar 8px



* remove bottom border in empty state



* wip



* fix original view monitors page



* fix original spacing



* run yarn test:jest -u



* upgrade to v4



---------


(cherry picked from commit 7dd95ec)

Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.17
# Create a new branch
git switch --create backport/backport-263-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7dd95ec17bebb0597e67afa059bd6d4161b83e2a
# Push it to GitHub
git push --set-upstream origin backport/backport-263-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-263-to-2.17.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.17
# Create a new branch
git switch --create backport/backport-263-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7dd95ec17bebb0597e67afa059bd6d4161b83e2a
# Push it to GitHub
git push --set-upstream origin backport/backport-263-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-263-to-2.17.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 17, 2024
* fill send test message button

Signed-off-by: Joanne Wang <[email protected]>

* extend content to full width of page

Signed-off-by: Joanne Wang <[email protected]>

* fix spacing across buttons (8px)

Signed-off-by: Joanne Wang <[email protected]>

* add vertical spacing

Signed-off-by: Joanne Wang <[email protected]>

* fix header and content 16px

Signed-off-by: Joanne Wang <[email protected]>

* remove extra 10px padding

Signed-off-by: Joanne Wang <[email protected]>

* align active indicator

Signed-off-by: Joanne Wang <[email protected]>

* wrap h2 in Eui Title with size s prop

Signed-off-by: Joanne Wang <[email protected]>

* fix padding for elements from search bar 8px

Signed-off-by: Joanne Wang <[email protected]>

* remove bottom border in empty state

Signed-off-by: Joanne Wang <[email protected]>

* wip

Signed-off-by: Joanne Wang <[email protected]>

* fix original view monitors page

Signed-off-by: Joanne Wang <[email protected]>

* fix original spacing

Signed-off-by: Joanne Wang <[email protected]>

* run yarn test:jest -u

Signed-off-by: Joanne Wang <[email protected]>

* upgrade to v4

Signed-off-by: Joanne Wang <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit 7dd95ec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit that referenced this pull request Sep 17, 2024
* fill send test message button



* extend content to full width of page



* fix spacing across buttons (8px)



* add vertical spacing



* fix header and content 16px



* remove extra 10px padding



* align active indicator



* wrap h2 in Eui Title with size s prop



* fix padding for elements from search bar 8px



* remove bottom border in empty state



* wip



* fix original view monitors page



* fix original spacing



* run yarn test:jest -u



* upgrade to v4



---------


(cherry picked from commit 7dd95ec)

Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jowg-amazon added a commit to jowg-amazon/dashboards-notifications that referenced this pull request Sep 24, 2024
jowg-amazon added a commit to jowg-amazon/dashboards-notifications that referenced this pull request Sep 24, 2024
AWSHurneyt pushed a commit that referenced this pull request Sep 24, 2024
* Revert "[Backport 2.17] Fit and Finish UX Fixes Pt 2. (#275)"

This reverts commit 5ac0919.

Signed-off-by: Joanne Wang <[email protected]>

* Revert "Fit and Finish UX Fixes (#263) (#269)"

This reverts commit b3dd31c.

Signed-off-by: Joanne Wang <[email protected]>

* Revert "Use TopNavControlButtonData for channel test button (#243) (#268)"

This reverts commit 127eae4.

Signed-off-by: Joanne Wang <[email protected]>

* Revert "[Fit & Finish] Updated Fit and Finish guidelines (#256) (#259)"

This reverts commit fb48dbc.

Signed-off-by: Joanne Wang <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants