-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fit and Finish UX Fixes #263
Conversation
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-263-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7dd95ec17bebb0597e67afa059bd6d4161b83e2a
# Push it to GitHub
git push --set-upstream origin backport/backport-263-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.17
# Create a new branch
git switch --create backport/backport-263-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7dd95ec17bebb0597e67afa059bd6d4161b83e2a
# Push it to GitHub
git push --set-upstream origin backport/backport-263-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.17 Then, create a pull request where the |
* fill send test message button Signed-off-by: Joanne Wang <[email protected]> * extend content to full width of page Signed-off-by: Joanne Wang <[email protected]> * fix spacing across buttons (8px) Signed-off-by: Joanne Wang <[email protected]> * add vertical spacing Signed-off-by: Joanne Wang <[email protected]> * fix header and content 16px Signed-off-by: Joanne Wang <[email protected]> * remove extra 10px padding Signed-off-by: Joanne Wang <[email protected]> * align active indicator Signed-off-by: Joanne Wang <[email protected]> * wrap h2 in Eui Title with size s prop Signed-off-by: Joanne Wang <[email protected]> * fix padding for elements from search bar 8px Signed-off-by: Joanne Wang <[email protected]> * remove bottom border in empty state Signed-off-by: Joanne Wang <[email protected]> * wip Signed-off-by: Joanne Wang <[email protected]> * fix original view monitors page Signed-off-by: Joanne Wang <[email protected]> * fix original spacing Signed-off-by: Joanne Wang <[email protected]> * run yarn test:jest -u Signed-off-by: Joanne Wang <[email protected]> * upgrade to v4 Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 7dd95ec) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fill send test message button * extend content to full width of page * fix spacing across buttons (8px) * add vertical spacing * fix header and content 16px * remove extra 10px padding * align active indicator * wrap h2 in Eui Title with size s prop * fix padding for elements from search bar 8px * remove bottom border in empty state * wip * fix original view monitors page * fix original spacing * run yarn test:jest -u * upgrade to v4 --------- (cherry picked from commit 7dd95ec) Signed-off-by: Joanne Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.17
# Create a new branch
git switch --create backport/backport-263-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7dd95ec17bebb0597e67afa059bd6d4161b83e2a
# Push it to GitHub
git push --set-upstream origin backport/backport-263-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.17 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.17
# Create a new branch
git switch --create backport/backport-263-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7dd95ec17bebb0597e67afa059bd6d4161b83e2a
# Push it to GitHub
git push --set-upstream origin backport/backport-263-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.17 Then, create a pull request where the |
* fill send test message button Signed-off-by: Joanne Wang <[email protected]> * extend content to full width of page Signed-off-by: Joanne Wang <[email protected]> * fix spacing across buttons (8px) Signed-off-by: Joanne Wang <[email protected]> * add vertical spacing Signed-off-by: Joanne Wang <[email protected]> * fix header and content 16px Signed-off-by: Joanne Wang <[email protected]> * remove extra 10px padding Signed-off-by: Joanne Wang <[email protected]> * align active indicator Signed-off-by: Joanne Wang <[email protected]> * wrap h2 in Eui Title with size s prop Signed-off-by: Joanne Wang <[email protected]> * fix padding for elements from search bar 8px Signed-off-by: Joanne Wang <[email protected]> * remove bottom border in empty state Signed-off-by: Joanne Wang <[email protected]> * wip Signed-off-by: Joanne Wang <[email protected]> * fix original view monitors page Signed-off-by: Joanne Wang <[email protected]> * fix original spacing Signed-off-by: Joanne Wang <[email protected]> * run yarn test:jest -u Signed-off-by: Joanne Wang <[email protected]> * upgrade to v4 Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 7dd95ec) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fill send test message button * extend content to full width of page * fix spacing across buttons (8px) * add vertical spacing * fix header and content 16px * remove extra 10px padding * align active indicator * wrap h2 in Eui Title with size s prop * fix padding for elements from search bar 8px * remove bottom border in empty state * wip * fix original view monitors page * fix original spacing * run yarn test:jest -u * upgrade to v4 --------- (cherry picked from commit 7dd95ec) Signed-off-by: Joanne Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…project#269)" This reverts commit b3dd31c.
…project#269)" This reverts commit b3dd31c. Signed-off-by: Joanne Wang <[email protected]>
* Revert "[Backport 2.17] Fit and Finish UX Fixes Pt 2. (#275)" This reverts commit 5ac0919. Signed-off-by: Joanne Wang <[email protected]> * Revert "Fit and Finish UX Fixes (#263) (#269)" This reverts commit b3dd31c. Signed-off-by: Joanne Wang <[email protected]> * Revert "Use TopNavControlButtonData for channel test button (#243) (#268)" This reverts commit 127eae4. Signed-off-by: Joanne Wang <[email protected]> * Revert "[Fit & Finish] Updated Fit and Finish guidelines (#256) (#259)" This reverts commit fb48dbc. Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]>
Description
Addresses the fit and finish UX changes. Changes in this PR include:
Empty Channels Page
Channels Page
Edit Channel Page
Email Senders Page
Create SMTP Sender Page
Create SES Sender Page
Email Recipient Group Page
Edit Recipient Group Page
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.