Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist dataSourceId across applications under new Nav change #244

Merged

Conversation

riysaxen-amzn
Copy link
Collaborator

@riysaxen-amzn riysaxen-amzn commented Aug 28, 2024

Description

  • This PR persists dataSourceId across applications under new Nav change and add dataSourceId in the URL

Issues Resolved

fix-mds.mov

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
@riysaxen-amzn riysaxen-amzn requested a review from amsiglan August 29, 2024 00:05
@riysaxen-amzn
Copy link
Collaborator Author

UTs passing locally:

 PASS  public/pages/Main/__tests__/Main.test.tsx (34.076 s)
 PASS  public/pages/Channels/__tests__/ChannelSettingsDetails.test.tsx (23.958 s)
 PASS  public/pages/CreateChannel/__tests__/EmailSettings.test.tsx (30.083 s)
 PASS  server/utils/__tests__/helper.test.ts (8.109 s)
 PASS  public/pages/Emails/__tests__/validationHelper.test.ts (10.825 s)
 PASS  public/utils/__tests__/helper.test.ts (10.231 s)
 PASS  public/pages/CreateChannel/__tests__/validationHelper.test.ts (10.832 s)
 PASS  public/pages/Emails/__tests__/helper.test.ts (9.279 s)
 PASS  public/pages/CreateChannel/__tests__/helper.test.ts (6.319 s)
 PASS  public/components/__tests__/ContentPanelActions.test.tsx (20.771 s)
 PASS  public/components/__tests__/Modal.test.tsx (22.695 s)
 PASS  public/pages/CreateChannel/__tests__/WebhookHeaders.test.tsx (22.783 s)
 PASS  public/components/__tests__/ContentPanel.test.tsx (20.366 s)
 PASS  public/pages/Channels/__tests__/DetailsListModal.test.tsx (19.872 s)
 PASS  public/pages/Emails/__tests__/EmailGroups.test.tsx (20.635 s)
A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active timers can also cause this, ensure that .unref() was called on them.

Test Suites: 45 passed, 45 total
Tests:       3 skipped, 146 passed, 149 total
Snapshots:   83 passed, 83 total
Time:        137.11 s


@riysaxen-amzn
Copy link
Collaborator Author

need to check with osd team why installation of notification plugin in osd is failing

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.72%. Comparing base (0bad488) to head (954c6f8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   82.79%   82.72%   -0.08%     
==========================================
  Files          55       55              
  Lines        1686     1702      +16     
  Branches      455      457       +2     
==========================================
+ Hits         1396     1408      +12     
- Misses        283      287       +4     
  Partials        7        7              
Flag Coverage Δ
dashboards-notifications 82.72% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@riysaxen-amzn riysaxen-amzn merged commit f209c40 into opensearch-project:main Sep 3, 2024
8 of 9 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-244-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f209c40d3124fb5a52fde7b081684aec4f7fc76f
# Push it to GitHub
git push --set-upstream origin backport/backport-244-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-244-to-2.x.

riysaxen-amzn added a commit to riysaxen-amzn/dashboards-notifications that referenced this pull request Sep 4, 2024
…arch-project#244)

* Persist dataSourceId across applications under new Nav change

Signed-off-by: Riya Saxena <[email protected]>

* fixes with mds

Signed-off-by: Riya Saxena <[email protected]>

* fixes with mds

Signed-off-by: Riya Saxena <[email protected]>

* fix UTs

Signed-off-by: Riya Saxena <[email protected]>

* moved to constants

Signed-off-by: Riya Saxena <[email protected]>

* revert changes in snapshot files

Signed-off-by: Riya Saxena <[email protected]>

---------

Signed-off-by: Riya Saxena <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit f209c40)
amsiglan pushed a commit that referenced this pull request Sep 4, 2024
…249)

* Persist dataSourceId across applications under new Nav change

Signed-off-by: Riya Saxena <[email protected]>

* fixes with mds

Signed-off-by: Riya Saxena <[email protected]>

* fixes with mds

Signed-off-by: Riya Saxena <[email protected]>

* fix UTs

Signed-off-by: Riya Saxena <[email protected]>

* moved to constants

Signed-off-by: Riya Saxena <[email protected]>

* revert changes in snapshot files

Signed-off-by: Riya Saxena <[email protected]>

---------

Signed-off-by: Riya Saxena <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit f209c40)

Signed-off-by: Riya <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 4, 2024
…249)

* Persist dataSourceId across applications under new Nav change

Signed-off-by: Riya Saxena <[email protected]>

* fixes with mds

Signed-off-by: Riya Saxena <[email protected]>

* fixes with mds

Signed-off-by: Riya Saxena <[email protected]>

* fix UTs

Signed-off-by: Riya Saxena <[email protected]>

* moved to constants

Signed-off-by: Riya Saxena <[email protected]>

* revert changes in snapshot files

Signed-off-by: Riya Saxena <[email protected]>

---------

Signed-off-by: Riya Saxena <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit f209c40)

Signed-off-by: Riya <[email protected]>
(cherry picked from commit 0bc8724)
riysaxen-amzn added a commit that referenced this pull request Sep 5, 2024
…249) (#255)

* Persist dataSourceId across applications under new Nav change

Signed-off-by: Riya Saxena <[email protected]>

* fixes with mds

Signed-off-by: Riya Saxena <[email protected]>

* fixes with mds

Signed-off-by: Riya Saxena <[email protected]>

* fix UTs

Signed-off-by: Riya Saxena <[email protected]>

* moved to constants

Signed-off-by: Riya Saxena <[email protected]>

* revert changes in snapshot files

Signed-off-by: Riya Saxena <[email protected]>

---------

Signed-off-by: Riya Saxena <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit f209c40)

Signed-off-by: Riya <[email protected]>
(cherry picked from commit 0bc8724)

Co-authored-by: Riya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants