Use TopNavControlButtonData for channel test button #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miki <[email protected]>
AMoo-Miki
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90,
praveensameneni,
amsiglan and
AWSHurneyt
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
=======================================
Coverage 82.79% 82.79%
=======================================
Files 55 55
Lines 1686 1686
Branches 455 455
=======================================
Hits 1396 1396
Misses 283 283
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hailong-am
approved these changes
Aug 24, 2024
amsiglan
approved these changes
Aug 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
Signed-off-by: Miki <[email protected]> (cherry picked from commit 6121bd4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Sep 4, 2024
(cherry picked from commit 6121bd4) Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Miki <[email protected]> (cherry picked from commit 6121bd4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Sep 17, 2024
(cherry picked from commit 6121bd4) Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jowg-amazon
added a commit
to jowg-amazon/dashboards-notifications
that referenced
this pull request
Sep 24, 2024
jowg-amazon
added a commit
to jowg-amazon/dashboards-notifications
that referenced
this pull request
Sep 24, 2024
…ch-project#243) (opensearch-project#268)" This reverts commit 127eae4. Signed-off-by: Joanne Wang <[email protected]>
AWSHurneyt
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Revert "[Backport 2.17] Fit and Finish UX Fixes Pt 2. (#275)" This reverts commit 5ac0919. Signed-off-by: Joanne Wang <[email protected]> * Revert "Fit and Finish UX Fixes (#263) (#269)" This reverts commit b3dd31c. Signed-off-by: Joanne Wang <[email protected]> * Revert "Use TopNavControlButtonData for channel test button (#243) (#268)" This reverts commit 127eae4. Signed-off-by: Joanne Wang <[email protected]> * Revert "[Fit & Finish] Updated Fit and Finish guidelines (#256) (#259)" This reverts commit fb48dbc. Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use TopNavControlButtonData for channel test button
Note: All other buttons and the general styling of the page are created wrongly and with custom styling so nothing matches.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.