Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable config file with ability to use local aws-proxy to access OpenSearch #12

Merged
merged 12 commits into from
Apr 27, 2022
Merged

Customizable config file with ability to use local aws-proxy to access OpenSearch #12

merged 12 commits into from
Apr 27, 2022

Conversation

johnnyon-amzn
Copy link
Contributor

Description

Set environment variables based on local config file and access OpenSearch with proxy credentials

Issues Resolved

#11

@johnnyon-amzn
Copy link
Contributor Author

Squashing for readability. Electron app with customizable config and ability to connect to aws proxy

@seraphjiang seraphjiang requested a review from a team April 26, 2022 22:44
@seraphjiang
Copy link
Member

Great progress,
a few comments in general

  1. move the code to src folder instead of put on project root folder
  2. could we add a few screen shot about what look UI looks like so far

@seraphjiang seraphjiang added the enhancement New feature or request label Apr 26, 2022
zhongnansu
zhongnansu reviewed Apr 26, 2022
View reviewed changes
Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add license headers to all files?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
config.json Outdated Show resolved Hide resolved
renderer.js Outdated Show resolved Hide resolved
@seraphjiang seraphjiang linked an issue Apr 27, 2022 that may be closed by this pull request
[FEATURE] Allow local proxy to connect to a specific osd domain #11
Open
seraphjiang and others added 11 commits April 27, 2022 12:55
@seraphjiang @johnnyon-amzn
Initial draft for project readme (#2)
ce191fd 
Signed-off-by: Huan Jiang <[email protected]>
Signed-off-by: Johnny On <[email protected]>
@seraphjiang @johnnyon-amzn
Fix broken anchor link in markdown (#5)
9023ff3 
* Initial draft for project readme

Signed-off-by: Huan Jiang <[email protected]>

* fix broken anchor link

Signed-off-by: Huan Jiang <[email protected]>
Signed-off-by: Johnny On <[email protected]>
@johnnyon-amzn
init electron
69298da 
Signed-off-by: Johnny On <[email protected]>
@johnnyon-amzn
sign off
6b16f71 
Signed-off-by: Johnny On <[email protected]>
@johnnyon-amzn
allow for config edits and add environment varaibles in proxy
dc932db 
Signed-off-by: Johnny On <[email protected]>
@johnnyon-amzn
remove config from git
e02f003 
Signed-off-by: Johnny On <[email protected]>
@johnnyon-amzn
Update config.json
5d790ec 
Signed-off-by: Johnny On <[email protected]>
@johnnyon-amzn
move all code files to src
0924bed 
Signed-off-by: Johnny On <[email protected]>
@johnnyon-amzn
edit paths and fix readme typos
8fb16b4 
Signed-off-by: Johnny On <[email protected]>
@johnnyon-amzn
Merge branch 'dev' into main
6ab1a64
@johnnyon-amzn
screenshots folder
53c9349 
Signed-off-by: Johnny On <[email protected]>
@johnnyon-amzn
Copy link
Contributor Author

Great progress, a few comments in general

  1. move the code to src folder instead of put on project root folder
  2. could we add a few screen shot about what look UI looks like so far

I migrated all code to the src folder, and changed the paths in commit 0924bed, 8fb16b4
I also added a screenshot for the initial page in commit 53c9349. I will add more screenshots for the next commits with opensearch dashboards connecting.

seraphjiang
seraphjiang approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@seraphjiang seraphjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider move css folder to src as well

Flyingliuhub
Flyingliuhub approved these changes Apr 27, 2022
View reviewed changes
.gitignore Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
zhongnansu
zhongnansu approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@johnnyon-amzn johnnyon-amzn merged commit 70f111b into opensearch-project:dev Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flyingliuhub Flyingliuhub Flyingliuhub approved these changes

@zhongnansu zhongnansu zhongnansu approved these changes

@seraphjiang seraphjiang seraphjiang approved these changes

Assignees

@johnnyon-amzn johnnyon-amzn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Allow local proxy to connect to a specific osd domain
4 participants
@johnnyon-amzn @seraphjiang @zhongnansu @Flyingliuhub