From 06c2d5c0ae878156d8549971ae1bb23bcfb732d3 Mon Sep 17 00:00:00 2001 From: Peter Zhu Date: Fri, 15 Nov 2024 14:41:03 -0500 Subject: [PATCH 1/3] Enable custom start commands and options to resolve GHA issues Signed-off-by: Peter Zhu --- .github/workflows/build.yml | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 44f6775e..a2974fbf 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -30,16 +30,11 @@ jobs: # this image tag is subject to change as more dependencies and updates will arrive over time image: ${{ needs.Get-CI-Image-Tag.outputs.ci-image-version-linux }} # need to switch to root so that github actions can install runner binary on container without permission issues. - options: --user root - - # actions/checkout@v4 and actions/setup-java@v4 use node 20: - # https://github.com/actions/checkout/releases/tag/v4.0.0 - # container image does not have GLIBC_2.28 required for this node version - # as such use @v3 actions instead for this workflow and set ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION - env: - ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true + options: ${{ needs.Get-CI-Image-Tag.outputs.ci-image-start-options }} steps: + - name: Run start commands + run: ${{ needs.Get-CI-Image-Tag.outputs.ci-image-start-command }} # This step uses the setup-java Github action: https://github.com/actions/setup-java - name: Set up JDK ${{ matrix.java }} for build and test uses: actions/setup-java@v3 From b0d0b391e9938f705acd3d0cf9a1f5601c201c55 Mon Sep 17 00:00:00 2001 From: Peter Zhu Date: Fri, 15 Nov 2024 14:43:12 -0500 Subject: [PATCH 2/3] Enable custom start commands and options to resolve GHA issues Signed-off-by: Peter Zhu --- .github/workflows/build.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a2974fbf..05802e3e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -43,7 +43,7 @@ jobs: java-version: ${{ matrix.java }} # This step uses the checkout Github action: https://github.com/actions/checkout - name: Checkout Branch - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Build with Gradle id: step-build-test-linux run: | @@ -57,7 +57,7 @@ jobs: uses: codecov/codecov-action@v1.2.1 with: token: ${{ secrets.CODECOV_TOKEN }} - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: async-plugin-linux-${{ matrix.java }} path: ${{ steps.step-build-test-linux.outputs.build-test-linux }} @@ -84,7 +84,7 @@ jobs: distribution: temurin # Temurin is a distribution of adoptium java-version: ${{ matrix.java }} - name: Checkout Branch - uses: actions/checkout@v3 + uses: actions/checkout@v4 - uses: actions/download-artifact@v3 with: name: async-plugin-linux-${{ matrix.java }} @@ -139,7 +139,7 @@ jobs: ./gradlew integTest -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername="docker-cluster" fi - name: Upload failed logs - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 if: failure() with: name: logs @@ -163,7 +163,7 @@ jobs: java-version: ${{ matrix.java }} # This step uses the checkout Github action: https://github.com/actions/checkout - name: Checkout Branch - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Build with Gradle run: ./gradlew.bat build -x integTest -x jacocoTestReport env: @@ -174,7 +174,7 @@ jobs: cp ./build/distributions/*.zip asynchronous-search-artifacts # This step uses the upload-artifact Github action: https://github.com/actions/upload-artifact - name: Upload Artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: asynchronous-search-plugin-windows path: asynchronous-search-artifacts @@ -197,7 +197,7 @@ jobs: java-version: ${{ matrix.java }} # This step uses the checkout Github action: https://github.com/actions/checkout - name: Checkout Branch - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Build with Gradle run: ./gradlew build -x integTest -x jacocoTestReport env: @@ -208,7 +208,7 @@ jobs: cp ./build/distributions/*.zip asynchronous-search-artifacts # This step uses the upload-artifact Github action: https://github.com/actions/upload-artifact - name: Upload Artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: asynchronous-search-plugin-mac path: asynchronous-search-artifacts From 9dfe20b5e6e031e23c7ad719ccfa353a9a32d3cf Mon Sep 17 00:00:00 2001 From: Peter Zhu Date: Fri, 15 Nov 2024 14:57:07 -0500 Subject: [PATCH 3/3] Enable custom start commands and options to resolve GHA issues Signed-off-by: Peter Zhu --- .github/workflows/build.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 05802e3e..171706fa 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -73,9 +73,6 @@ jobs: # This job runs on Linux. runs-on: ubuntu-latest - env: # actions/checkout uses node 16 - ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true - steps: # This step uses the setup-java Github action: https://github.com/actions/setup-java - name: Set Up JDK ${{ matrix.java }} @@ -85,7 +82,7 @@ jobs: java-version: ${{ matrix.java }} - name: Checkout Branch uses: actions/checkout@v4 - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: async-plugin-linux-${{ matrix.java }} - name: Pull and Run Docker for security tests