Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting plugin supports sending html format email #1051

Open
gaobinlong opened this issue Jul 19, 2023 · 1 comment
Open

Alerting plugin supports sending html format email #1051

gaobinlong opened this issue Jul 19, 2023 · 1 comment
Assignees

Comments

@gaobinlong
Copy link

gaobinlong commented Jul 19, 2023

Relates to opensearch-project/notifications#586.

Some users asked if we can support sending html format alerting email, but html format email may introduce security issue so we implemented html sanitization in notification plugin which can sanitize the html email before sending it, the PR in notification plugin is opensearch-project/notifications#694, and there are still some work need to be done in alerting plugin to make the feature complete, the following shows the work:

  1. common-utils plugin: need to add a bool parameter such as isHtmlFormatMessage to identify whether the email message is html format or not, we have to add the parameter into this plugin because most of the objects like monitor, triggers used by alerting plugin are defined in this plugin.

  2. alerting plugin: create or update monitor API can accept the bool parameter isHtmlFormatMessage, when calling the sendNotification method to send email, if isHtmlFormatMessage is true, use htmlDescription parameter instead of textDescription.

@gaobinlong
Copy link
Author

gaobinlong commented Jul 19, 2023

@lezzago can you help to assign this issue to me? I'll do the task.

@gaobinlong gaobinlong changed the title Alerting plugin support sending html format email Alerting plugin supports sending html format email Jul 19, 2023
@lezzago lezzago removed the untriaged label Jul 26, 2023
@github-project-automation github-project-automation bot moved this to Upcoming release (TBD) in OpenSearch Project Roadmap Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Upcoming release (TBD)
Development

No branches or pull requests

2 participants