diff --git a/.github/workflows/multi-node-test-workflow.yml b/.github/workflows/multi-node-test-workflow.yml index 9f76b2263..5120d8aed 100644 --- a/.github/workflows/multi-node-test-workflow.yml +++ b/.github/workflows/multi-node-test-workflow.yml @@ -27,4 +27,4 @@ jobs: - name: Checkout Branch uses: actions/checkout@v2 - name: Run integration tests with multi node config - run: ./gradlew integTest -PnumNodes=3 -Dopensearch.version=1.3.0-SNAPSHOT + run: ./gradlew integTest -PnumNodes=3 -Dopensearch.version=2.0.0-SNAPSHOT diff --git a/.github/workflows/security-test-workflow.yml b/.github/workflows/security-test-workflow.yml index 581ab0098..3c2a47377 100644 --- a/.github/workflows/security-test-workflow.yml +++ b/.github/workflows/security-test-workflow.yml @@ -33,7 +33,7 @@ jobs: java-version: 11 - name: Build Alerting # Only assembling since the full build is governed by other workflows - run: ./gradlew assemble -Dopensearch.version=1.3.0-SNAPSHOT + run: ./gradlew assemble -Dopensearch.version=2.0.0-SNAPSHOT - name: Pull and Run Docker run: | plugin=`ls alerting/build/distributions/*.zip` diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml index ffb87287a..657586c12 100644 --- a/.github/workflows/test-workflow.yml +++ b/.github/workflows/test-workflow.yml @@ -12,7 +12,7 @@ jobs: build: strategy: matrix: - java: [8, 11, 14] + java: [11, 14] # Job name name: Build Alerting with JDK ${{ matrix.java }} # This job runs on Linux @@ -27,7 +27,7 @@ jobs: with: java-version: ${{ matrix.java }} - name: Build and run with Gradle - run: ./gradlew build -Dopensearch.version=1.3.0-SNAPSHOT + run: ./gradlew build -Dopensearch.version=2.0.0-SNAPSHOT - name: Create Artifact Path run: | mkdir -p alerting-artifacts diff --git a/alerting/build.gradle b/alerting/build.gradle index 2799c9167..40f5ab373 100644 --- a/alerting/build.gradle +++ b/alerting/build.gradle @@ -50,7 +50,7 @@ configurations.all { } } -configurations.testCompile { +configurations.testImplementation { exclude module: "securemock" } @@ -58,16 +58,16 @@ dependencies { compileOnly "org.opensearch.plugin:opensearch-scripting-painless-spi:${versions.opensearch}" // OpenSearch Nanny state - compile "org.jetbrains.kotlin:kotlin-stdlib:${kotlin_version}" - compile "org.jetbrains.kotlin:kotlin-stdlib-common:${kotlin_version}" - compile "org.jetbrains:annotations:13.0" + implementation "org.jetbrains.kotlin:kotlin-stdlib:${kotlin_version}" + implementation "org.jetbrains.kotlin:kotlin-stdlib-common:${kotlin_version}" + implementation "org.jetbrains:annotations:13.0" - compile project(":alerting-core") - compile project(":alerting-notification") + api project(":alerting-core") + api project(":alerting-notification") implementation "com.github.seancfoley:ipaddress:5.3.3" testImplementation "org.jetbrains.kotlin:kotlin-test:${kotlin_version}" - testCompile "org.mockito:mockito-core:3.12.4" + testImplementation "org.mockito:mockito-core:4.3.1" } javadoc.enabled = false // turn off javadoc as it barfs on Kotlin code @@ -161,7 +161,7 @@ String bwcFilePath = "src/test/resources/bwc" testClusters { "${baseName}$i" { testDistribution = "ARCHIVE" - versions = ["7.10.2","1.3.0-SNAPSHOT"] + versions = ["7.10.2","2.0.0-SNAPSHOT"] numberOfNodes = 3 plugin(provider(new Callable(){ @Override diff --git a/alerting/src/main/kotlin/org/opensearch/alerting/alerts/AlertIndices.kt b/alerting/src/main/kotlin/org/opensearch/alerting/alerts/AlertIndices.kt index 366691423..0c0faa5f4 100644 --- a/alerting/src/main/kotlin/org/opensearch/alerting/alerts/AlertIndices.kt +++ b/alerting/src/main/kotlin/org/opensearch/alerting/alerts/AlertIndices.kt @@ -236,7 +236,7 @@ class AlertIndices( return } - var putMappingRequest: PutMappingRequest = PutMappingRequest(targetIndex).type(MAPPING_TYPE) + var putMappingRequest: PutMappingRequest = PutMappingRequest(targetIndex) .source(mapping, XContentType.JSON) val updateResponse: AcknowledgedResponse = client.admin().indices().suspendUntil { putMapping(putMappingRequest, it) } if (updateResponse.isAcknowledged) { diff --git a/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexDestinationAction.kt b/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexDestinationAction.kt index 5ad5acd7d..8a5d4daef 100644 --- a/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexDestinationAction.kt +++ b/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexDestinationAction.kt @@ -117,7 +117,7 @@ class TransportIndexDestinationAction @Inject constructor( }) } else if (!IndexUtils.scheduledJobIndexUpdated) { IndexUtils.updateIndexMapping( - ScheduledJob.SCHEDULED_JOBS_INDEX, ScheduledJob.SCHEDULED_JOB_TYPE, + ScheduledJob.SCHEDULED_JOBS_INDEX, ScheduledJobIndices.scheduledJobMappings(), clusterService.state(), client.admin().indices(), object : ActionListener { override fun onResponse(response: AcknowledgedResponse) { diff --git a/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexEmailAccountAction.kt b/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexEmailAccountAction.kt index 1c49908bc..c1349e3a9 100644 --- a/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexEmailAccountAction.kt +++ b/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexEmailAccountAction.kt @@ -23,7 +23,6 @@ import org.opensearch.alerting.action.IndexEmailAccountRequest import org.opensearch.alerting.action.IndexEmailAccountResponse import org.opensearch.alerting.core.ScheduledJobIndices import org.opensearch.alerting.core.model.ScheduledJob.Companion.SCHEDULED_JOBS_INDEX -import org.opensearch.alerting.core.model.ScheduledJob.Companion.SCHEDULED_JOB_TYPE import org.opensearch.alerting.model.destination.email.EmailAccount import org.opensearch.alerting.settings.AlertingSettings.Companion.INDEX_TIMEOUT import org.opensearch.alerting.settings.AlertingSettings.Companion.REQUEST_TIMEOUT @@ -94,7 +93,7 @@ class TransportIndexEmailAccountAction @Inject constructor( }) } else if (!IndexUtils.scheduledJobIndexUpdated) { IndexUtils.updateIndexMapping( - SCHEDULED_JOBS_INDEX, SCHEDULED_JOB_TYPE, + SCHEDULED_JOBS_INDEX, ScheduledJobIndices.scheduledJobMappings(), clusterService.state(), client.admin().indices(), object : ActionListener { override fun onResponse(response: AcknowledgedResponse) { diff --git a/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexEmailGroupAction.kt b/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexEmailGroupAction.kt index 00e4f17ec..a89e2cab6 100644 --- a/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexEmailGroupAction.kt +++ b/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexEmailGroupAction.kt @@ -21,7 +21,6 @@ import org.opensearch.alerting.action.IndexEmailGroupRequest import org.opensearch.alerting.action.IndexEmailGroupResponse import org.opensearch.alerting.core.ScheduledJobIndices import org.opensearch.alerting.core.model.ScheduledJob.Companion.SCHEDULED_JOBS_INDEX -import org.opensearch.alerting.core.model.ScheduledJob.Companion.SCHEDULED_JOB_TYPE import org.opensearch.alerting.settings.AlertingSettings.Companion.INDEX_TIMEOUT import org.opensearch.alerting.settings.DestinationSettings.Companion.ALLOW_LIST import org.opensearch.alerting.util.AlertingException @@ -86,7 +85,7 @@ class TransportIndexEmailGroupAction @Inject constructor( }) } else if (!IndexUtils.scheduledJobIndexUpdated) { IndexUtils.updateIndexMapping( - SCHEDULED_JOBS_INDEX, SCHEDULED_JOB_TYPE, + SCHEDULED_JOBS_INDEX, ScheduledJobIndices.scheduledJobMappings(), clusterService.state(), client.admin().indices(), object : ActionListener { override fun onResponse(response: AcknowledgedResponse) { diff --git a/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexMonitorAction.kt b/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexMonitorAction.kt index 12738a94b..e4f04770d 100644 --- a/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexMonitorAction.kt +++ b/alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportIndexMonitorAction.kt @@ -25,7 +25,6 @@ import org.opensearch.alerting.action.IndexMonitorResponse import org.opensearch.alerting.core.ScheduledJobIndices import org.opensearch.alerting.core.model.ScheduledJob import org.opensearch.alerting.core.model.ScheduledJob.Companion.SCHEDULED_JOBS_INDEX -import org.opensearch.alerting.core.model.ScheduledJob.Companion.SCHEDULED_JOB_TYPE import org.opensearch.alerting.core.model.SearchInput import org.opensearch.alerting.model.Monitor import org.opensearch.alerting.settings.AlertingSettings @@ -243,7 +242,7 @@ class TransportIndexMonitorAction @Inject constructor( }) } else if (!IndexUtils.scheduledJobIndexUpdated) { IndexUtils.updateIndexMapping( - SCHEDULED_JOBS_INDEX, SCHEDULED_JOB_TYPE, + SCHEDULED_JOBS_INDEX, ScheduledJobIndices.scheduledJobMappings(), clusterService.state(), client.admin().indices(), object : ActionListener { override fun onResponse(response: AcknowledgedResponse) { diff --git a/alerting/src/main/kotlin/org/opensearch/alerting/util/IndexUtils.kt b/alerting/src/main/kotlin/org/opensearch/alerting/util/IndexUtils.kt index 7bf1eade5..e0ce289a8 100644 --- a/alerting/src/main/kotlin/org/opensearch/alerting/util/IndexUtils.kt +++ b/alerting/src/main/kotlin/org/opensearch/alerting/util/IndexUtils.kt @@ -105,7 +105,6 @@ class IndexUtils { @JvmStatic fun updateIndexMapping( index: String, - type: String, mapping: String, clusterState: ClusterState, client: IndicesAdminClient, @@ -113,7 +112,7 @@ class IndexUtils { ) { if (clusterState.metadata.indices.containsKey(index)) { if (shouldUpdateIndex(clusterState.metadata.indices[index], mapping)) { - val putMappingRequest: PutMappingRequest = PutMappingRequest(index).type(type).source(mapping, XContentType.JSON) + val putMappingRequest: PutMappingRequest = PutMappingRequest(index).source(mapping, XContentType.JSON) client.putMapping(putMappingRequest, actionListener) } else { actionListener.onResponse(AcknowledgedResponse(true)) diff --git a/alerting/src/test/kotlin/org/opensearch/alerting/AlertingRestTestCase.kt b/alerting/src/test/kotlin/org/opensearch/alerting/AlertingRestTestCase.kt index c73c8a9a2..a12f187b1 100644 --- a/alerting/src/test/kotlin/org/opensearch/alerting/AlertingRestTestCase.kt +++ b/alerting/src/test/kotlin/org/opensearch/alerting/AlertingRestTestCase.kt @@ -79,7 +79,7 @@ abstract class AlertingRestTestCase : ODFERestTestCase() { SearchInput.XCONTENT_REGISTRY, QueryLevelTrigger.XCONTENT_REGISTRY, BucketLevelTrigger.XCONTENT_REGISTRY - ) + SearchModule(Settings.EMPTY, false, emptyList()).namedXContents + ) + SearchModule(Settings.EMPTY, emptyList()).namedXContents ) } diff --git a/alerting/src/test/kotlin/org/opensearch/alerting/TestHelpers.kt b/alerting/src/test/kotlin/org/opensearch/alerting/TestHelpers.kt index 7c8ab14bc..f16ef1c40 100644 --- a/alerting/src/test/kotlin/org/opensearch/alerting/TestHelpers.kt +++ b/alerting/src/test/kotlin/org/opensearch/alerting/TestHelpers.kt @@ -527,7 +527,7 @@ fun xContentRegistry(): NamedXContentRegistry { return NamedXContentRegistry( listOf( SearchInput.XCONTENT_REGISTRY, QueryLevelTrigger.XCONTENT_REGISTRY, BucketLevelTrigger.XCONTENT_REGISTRY - ) + SearchModule(Settings.EMPTY, false, emptyList()).namedXContents + ) + SearchModule(Settings.EMPTY, emptyList()).namedXContents ) } diff --git a/alerting/src/test/kotlin/org/opensearch/alerting/util/IndexUtilsTests.kt b/alerting/src/test/kotlin/org/opensearch/alerting/util/IndexUtilsTests.kt index e2e6a285d..e4db20639 100644 --- a/alerting/src/test/kotlin/org/opensearch/alerting/util/IndexUtilsTests.kt +++ b/alerting/src/test/kotlin/org/opensearch/alerting/util/IndexUtilsTests.kt @@ -78,10 +78,12 @@ class IndexUtilsTests : OpenSearchTestCase() { fun `test should update index with same version`() { val indexContent = "{\"testIndex\":{\"settings\":{\"index\":{\"creation_date\":\"1558407515699\"," + "\"number_of_shards\":\"1\",\"number_of_replicas\":\"1\",\"uuid\":\"t-VBBW6aR6KpJ3XP5iISOA\"," + - "\"version\":{\"created\":\"6040399\"},\"provided_name\":\"data_test\"}},\"mappings\":" + + "\"version\":{\"created\":\"6040399\"},\"provided_name\":\"data_test\"}},\"mapping_version\":\"1\"," + + "\"settings_version\":\"1\",\"aliases_version\":\"1\",\"mappings\":" + "{\"_doc\":{\"_meta\":{\"schema_version\":1},\"properties\":{\"name\":{\"type\":\"keyword\"}}}}}}" val newMapping = "{\"_meta\":{\"schema_version\":1},\"properties\":{\"name\":{\"type\":\"keyword\"}}}" - val index: IndexMetadata = IndexMetadata.fromXContent(parser(indexContent)) + val xContentParser = parser(indexContent) + val index: IndexMetadata = IndexMetadata.fromXContent(xContentParser) val shouldUpdateIndex = IndexUtils.shouldUpdateIndex(index, newMapping) assertFalse(shouldUpdateIndex) diff --git a/build.gradle b/build.gradle index 11733b155..eef8871ec 100644 --- a/build.gradle +++ b/build.gradle @@ -7,7 +7,7 @@ buildscript { apply from: 'build-tools/repositories.gradle' ext { - opensearch_version = System.getProperty("opensearch.version", "1.3.0-SNAPSHOT") + opensearch_version = System.getProperty("opensearch.version", "2.0.0-SNAPSHOT") // 1.0.0 -> 1.0.0.0, and 1.0.0-SNAPSHOT -> 1.0.0.0-SNAPSHOT opensearch_build = opensearch_version.replaceAll(/(\.\d)([^\d]*)$/, '$1.0$2') common_utils_version = System.getProperty("common_utils.version", opensearch_build) @@ -77,10 +77,10 @@ allprojects { apply from: "$rootDir/build-tools/repositories.gradle" plugins.withId('java') { - sourceCompatibility = targetCompatibility = "1.8" + sourceCompatibility = targetCompatibility = JavaVersion.VERSION_11 } plugins.withId('org.jetbrains.kotlin.jvm') { - compileKotlin.kotlinOptions.jvmTarget = compileTestKotlin.kotlinOptions.jvmTarget = "1.8" + compileKotlin.kotlinOptions.jvmTarget = compileTestKotlin.kotlinOptions.jvmTarget = JavaVersion.VERSION_11 compileKotlin.dependsOn ktlint } } diff --git a/core/build.gradle b/core/build.gradle index 62713f903..bf239f8c6 100644 --- a/core/build.gradle +++ b/core/build.gradle @@ -9,14 +9,14 @@ apply plugin: 'jacoco' dependencies { compileOnly "org.opensearch:opensearch:${opensearch_version}" - compile "org.jetbrains.kotlin:kotlin-stdlib:${kotlin_version}" - compile 'org.jetbrains.kotlinx:kotlinx-coroutines-core:1.1.1' - compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8:${kotlin_version}" - compile "com.cronutils:cron-utils:9.1.6" - compile "org.opensearch.client:opensearch-rest-client:${opensearch_version}" - compile 'com.google.googlejavaformat:google-java-format:1.10.0' - compile "org.opensearch:common-utils:${common_utils_version}" - compile 'commons-validator:commons-validator:1.7' + implementation "org.jetbrains.kotlin:kotlin-stdlib:${kotlin_version}" + api 'org.jetbrains.kotlinx:kotlinx-coroutines-core:1.1.1' + api "org.jetbrains.kotlin:kotlin-stdlib-jdk8:${kotlin_version}" + implementation "com.cronutils:cron-utils:9.1.6" + api "org.opensearch.client:opensearch-rest-client:${opensearch_version}" + implementation 'com.google.googlejavaformat:google-java-format:1.10.0' + api "org.opensearch:common-utils:${common_utils_version}" + implementation 'commons-validator:commons-validator:1.7' testImplementation "org.opensearch.test:framework:${opensearch_version}" testImplementation "org.jetbrains.kotlin:kotlin-test:${kotlin_version}" diff --git a/core/src/test/kotlin/org/opensearch/alerting/core/model/XContentTestBase.kt b/core/src/test/kotlin/org/opensearch/alerting/core/model/XContentTestBase.kt index 7ff983166..4a4140954 100644 --- a/core/src/test/kotlin/org/opensearch/alerting/core/model/XContentTestBase.kt +++ b/core/src/test/kotlin/org/opensearch/alerting/core/model/XContentTestBase.kt @@ -27,7 +27,7 @@ interface XContentTestBase { fun xContentRegistry(): NamedXContentRegistry { return NamedXContentRegistry( listOf(SearchInput.XCONTENT_REGISTRY) + - SearchModule(Settings.EMPTY, false, emptyList()).namedXContents + SearchModule(Settings.EMPTY, emptyList()).namedXContents ) } } diff --git a/gradle/wrapper/gradle-wrapper.jar b/gradle/wrapper/gradle-wrapper.jar index e708b1c02..7454180f2 100644 Binary files a/gradle/wrapper/gradle-wrapper.jar and b/gradle/wrapper/gradle-wrapper.jar differ diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index 12d38de6a..2e6e5897b 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,5 +1,5 @@ distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-6.6.1-bin.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-bin.zip zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists diff --git a/gradlew b/gradlew index 175d9c780..1b6c78733 100755 --- a/gradlew +++ b/gradlew @@ -1,15 +1,7 @@ -#!/usr/bin/env sh +#!/bin/sh # -# Copyright OpenSearch Contributors -# SPDX-License-Identifier: Apache-2.0 -# -# Modifications Copyright OpenSearch Contributors. See -# GitHub history for details. -# - -# -# Copyright 2015 the original author or authors. +# Copyright © 2015-2021 the original authors. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -25,67 +17,101 @@ # ############################################################################## -## -## Gradle start up script for UN*X -## +# +# Gradle start up script for POSIX generated by Gradle. +# +# Important for running: +# +# (1) You need a POSIX-compliant shell to run this script. If your /bin/sh is +# noncompliant, but you have some other compliant shell such as ksh or +# bash, then to run this script, type that shell name before the whole +# command line, like: +# +# ksh Gradle +# +# Busybox and similar reduced shells will NOT work, because this script +# requires all of these POSIX shell features: +# * functions; +# * expansions «$var», «${var}», «${var:-default}», «${var+SET}», +# «${var#prefix}», «${var%suffix}», and «$( cmd )»; +# * compound commands having a testable exit status, especially «case»; +# * various built-in commands including «command», «set», and «ulimit». +# +# Important for patching: +# +# (2) This script targets any POSIX shell, so it avoids extensions provided +# by Bash, Ksh, etc; in particular arrays are avoided. +# +# The "traditional" practice of packing multiple parameters into a +# space-separated string is a well documented source of bugs and security +# problems, so this is (mostly) avoided, by progressively accumulating +# options in "$@", and eventually passing that to Java. +# +# Where the inherited environment variables (DEFAULT_JVM_OPTS, JAVA_OPTS, +# and GRADLE_OPTS) rely on word-splitting, this is performed explicitly; +# see the in-line comments for details. +# +# There are tweaks for specific operating systems such as AIX, CygWin, +# Darwin, MinGW, and NonStop. +# +# (3) This script is generated from the Groovy template +# https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt +# within the Gradle project. +# +# You can find Gradle at https://github.com/gradle/gradle/. +# ############################################################################## # Attempt to set APP_HOME + # Resolve links: $0 may be a link -PRG="$0" -# Need this for relative symlinks. -while [ -h "$PRG" ] ; do - ls=`ls -ld "$PRG"` - link=`expr "$ls" : '.*-> \(.*\)$'` - if expr "$link" : '/.*' > /dev/null; then - PRG="$link" - else - PRG=`dirname "$PRG"`"/$link" - fi +app_path=$0 + +# Need this for daisy-chained symlinks. +while + APP_HOME=${app_path%"${app_path##*/}"} # leaves a trailing /; empty if no leading path + [ -h "$app_path" ] +do + ls=$( ls -ld "$app_path" ) + link=${ls#*' -> '} + case $link in #( + /*) app_path=$link ;; #( + *) app_path=$APP_HOME$link ;; + esac done -SAVED="`pwd`" -cd "`dirname \"$PRG\"`/" >/dev/null -APP_HOME="`pwd -P`" -cd "$SAVED" >/dev/null + +APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit APP_NAME="Gradle" -APP_BASE_NAME=`basename "$0"` +APP_BASE_NAME=${0##*/} # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' # Use the maximum available, or set MAX_FD != -1 to use that value. -MAX_FD="maximum" +MAX_FD=maximum warn () { echo "$*" -} +} >&2 die () { echo echo "$*" echo exit 1 -} +} >&2 # OS specific support (must be 'true' or 'false'). cygwin=false msys=false darwin=false nonstop=false -case "`uname`" in - CYGWIN* ) - cygwin=true - ;; - Darwin* ) - darwin=true - ;; - MINGW* ) - msys=true - ;; - NONSTOP* ) - nonstop=true - ;; +case "$( uname )" in #( + CYGWIN* ) cygwin=true ;; #( + Darwin* ) darwin=true ;; #( + MSYS* | MINGW* ) msys=true ;; #( + NONSTOP* ) nonstop=true ;; esac CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar @@ -95,9 +121,9 @@ CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar if [ -n "$JAVA_HOME" ] ; then if [ -x "$JAVA_HOME/jre/sh/java" ] ; then # IBM's JDK on AIX uses strange locations for the executables - JAVACMD="$JAVA_HOME/jre/sh/java" + JAVACMD=$JAVA_HOME/jre/sh/java else - JAVACMD="$JAVA_HOME/bin/java" + JAVACMD=$JAVA_HOME/bin/java fi if [ ! -x "$JAVACMD" ] ; then die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME @@ -106,7 +132,7 @@ Please set the JAVA_HOME variable in your environment to match the location of your Java installation." fi else - JAVACMD="java" + JAVACMD=java which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. Please set the JAVA_HOME variable in your environment to match the @@ -114,80 +140,95 @@ location of your Java installation." fi # Increase the maximum file descriptors if we can. -if [ "$cygwin" = "false" -a "$darwin" = "false" -a "$nonstop" = "false" ] ; then - MAX_FD_LIMIT=`ulimit -H -n` - if [ $? -eq 0 ] ; then - if [ "$MAX_FD" = "maximum" -o "$MAX_FD" = "max" ] ; then - MAX_FD="$MAX_FD_LIMIT" - fi - ulimit -n $MAX_FD - if [ $? -ne 0 ] ; then - warn "Could not set maximum file descriptor limit: $MAX_FD" - fi - else - warn "Could not query maximum file descriptor limit: $MAX_FD_LIMIT" - fi +if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then + case $MAX_FD in #( + max*) + MAX_FD=$( ulimit -H -n ) || + warn "Could not query maximum file descriptor limit" + esac + case $MAX_FD in #( + '' | soft) :;; #( + *) + ulimit -n "$MAX_FD" || + warn "Could not set maximum file descriptor limit to $MAX_FD" + esac fi -# For Darwin, add options to specify how the application appears in the dock -if $darwin; then - GRADLE_OPTS="$GRADLE_OPTS \"-Xdock:name=$APP_NAME\" \"-Xdock:icon=$APP_HOME/media/gradle.icns\"" -fi +# Collect all arguments for the java command, stacking in reverse order: +# * args from the command line +# * the main class name +# * -classpath +# * -D...appname settings +# * --module-path (only if needed) +# * DEFAULT_JVM_OPTS, JAVA_OPTS, and GRADLE_OPTS environment variables. # For Cygwin or MSYS, switch paths to Windows format before running java -if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then - APP_HOME=`cygpath --path --mixed "$APP_HOME"` - CLASSPATH=`cygpath --path --mixed "$CLASSPATH"` - - JAVACMD=`cygpath --unix "$JAVACMD"` - - # We build the pattern for arguments to be converted via cygpath - ROOTDIRSRAW=`find -L / -maxdepth 1 -mindepth 1 -type d 2>/dev/null` - SEP="" - for dir in $ROOTDIRSRAW ; do - ROOTDIRS="$ROOTDIRS$SEP$dir" - SEP="|" - done - OURCYGPATTERN="(^($ROOTDIRS))" - # Add a user-defined pattern to the cygpath arguments - if [ "$GRADLE_CYGPATTERN" != "" ] ; then - OURCYGPATTERN="$OURCYGPATTERN|($GRADLE_CYGPATTERN)" - fi +if "$cygwin" || "$msys" ; then + APP_HOME=$( cygpath --path --mixed "$APP_HOME" ) + CLASSPATH=$( cygpath --path --mixed "$CLASSPATH" ) + + JAVACMD=$( cygpath --unix "$JAVACMD" ) + # Now convert the arguments - kludge to limit ourselves to /bin/sh - i=0 - for arg in "$@" ; do - CHECK=`echo "$arg"|egrep -c "$OURCYGPATTERN" -` - CHECK2=`echo "$arg"|egrep -c "^-"` ### Determine if an option - - if [ $CHECK -ne 0 ] && [ $CHECK2 -eq 0 ] ; then ### Added a condition - eval `echo args$i`=`cygpath --path --ignore --mixed "$arg"` - else - eval `echo args$i`="\"$arg\"" + for arg do + if + case $arg in #( + -*) false ;; # don't mess with options #( + /?*) t=${arg#/} t=/${t%%/*} # looks like a POSIX filepath + [ -e "$t" ] ;; #( + *) false ;; + esac + then + arg=$( cygpath --path --ignore --mixed "$arg" ) fi - i=`expr $i + 1` + # Roll the args list around exactly as many times as the number of + # args, so each arg winds up back in the position where it started, but + # possibly modified. + # + # NB: a `for` loop captures its iteration list before it begins, so + # changing the positional parameters here affects neither the number of + # iterations, nor the values presented in `arg`. + shift # remove old arg + set -- "$@" "$arg" # push replacement arg done - case $i in - 0) set -- ;; - 1) set -- "$args0" ;; - 2) set -- "$args0" "$args1" ;; - 3) set -- "$args0" "$args1" "$args2" ;; - 4) set -- "$args0" "$args1" "$args2" "$args3" ;; - 5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;; - 6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;; - 7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;; - 8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;; - 9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;; - esac fi -# Escape application args -save () { - for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done - echo " " -} -APP_ARGS=`save "$@"` +# Collect all arguments for the java command; +# * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of +# shell script including quotes and variable substitutions, so put them in +# double quotes to make sure that they get re-expanded; and +# * put everything else in single quotes, so that it's not re-expanded. + +set -- \ + "-Dorg.gradle.appname=$APP_BASE_NAME" \ + -classpath "$CLASSPATH" \ + org.gradle.wrapper.GradleWrapperMain \ + "$@" + +# Use "xargs" to parse quoted args. +# +# With -n1 it outputs one arg per line, with the quotes and backslashes removed. +# +# In Bash we could simply go: +# +# readarray ARGS < <( xargs -n1 <<<"$var" ) && +# set -- "${ARGS[@]}" "$@" +# +# but POSIX shell has neither arrays nor command substitution, so instead we +# post-process each arg (as a line of input to sed) to backslash-escape any +# character that might be a shell metacharacter, then use eval to reverse +# that process (while maintaining the separation between arguments), and wrap +# the whole thing up as a single "set" statement. +# +# This will of course break if any of these variables contains a newline or +# an unmatched quote. +# -# Collect all arguments for the java command, following the shell quoting and substitution rules -eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS" +eval "set -- $( + printf '%s\n' "$DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS" | + xargs -n1 | + sed ' s~[^-[:alnum:]+,./:=@_]~\\&~g; ' | + tr '\n' ' ' + )" '"$@"' exec "$JAVACMD" "$@" diff --git a/gradlew.bat b/gradlew.bat index e774b62fa..ac1b06f93 100644 --- a/gradlew.bat +++ b/gradlew.bat @@ -1,8 +1,18 @@ @rem -@rem Copyright OpenSearch Contributors -@rem SPDX-License-Identifier: Apache-2.0 +@rem Copyright 2015 the original author or authors. +@rem +@rem Licensed under the Apache License, Version 2.0 (the "License"); +@rem you may not use this file except in compliance with the License. +@rem You may obtain a copy of the License at +@rem +@rem https://www.apache.org/licenses/LICENSE-2.0 +@rem +@rem Unless required by applicable law or agreed to in writing, software +@rem distributed under the License is distributed on an "AS IS" BASIS, +@rem WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +@rem See the License for the specific language governing permissions and +@rem limitations under the License. @rem - @if "%DEBUG%" == "" @echo off @rem ########################################################################## diff --git a/notification/build.gradle b/notification/build.gradle index 7e3913830..9bb548871 100644 --- a/notification/build.gradle +++ b/notification/build.gradle @@ -11,9 +11,9 @@ apply plugin: 'signing' dependencies { compileOnly "org.opensearch:opensearch:${opensearch_version}" - compile "org.apache.httpcomponents:httpcore:4.4.5" - compile "org.apache.httpcomponents:httpclient:4.5.13" - compile "com.sun.mail:javax.mail:1.6.2" + implementation "org.apache.httpcomponents:httpcore:4.4.5" + implementation "org.apache.httpcomponents:httpclient:4.5.13" + implementation "com.sun.mail:javax.mail:1.6.2" testImplementation "org.opensearch.test:framework:${opensearch_version}" testImplementation "org.easymock:easymock:4.0.1"