Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip gradle check that doesn't run gradle checks but passes the run gradle check requirement. #813

Closed
dblock opened this issue Jun 3, 2021 · 1 comment
Labels
enhancement Enhancement or improvement to existing feature or request

Comments

@dblock
Copy link
Member

dblock commented Jun 3, 2021

Is your feature request related to a problem? Please describe.

We often make PRs such as #812 that are a README change or similar trivialities. This wastes a costly and time-consuming run gradle check.

Describe the solution you'd like

Admins should be able to comment run gradle check or skip gradle check which will respectively run or skip gradle check and satisfy the gradle check requirement. It should also be clear which one was chosen when looking at a PR.

Describe alternatives you've considered

Just always run gradle checks. In that case I'd want to be able to [skip gradle check] in the commit message.

Additional context

Related to https://github.com/opensearch-project/OpenSearch/issues/597

@dblock dblock added enhancement Enhancement or improvement to existing feature or request untriaged labels Jun 3, 2021
@dblock dblock removed the untriaged label Jul 22, 2021
@andrross
Copy link
Member

Closing now that #13498 is implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

No branches or pull requests

2 participants