[BUG] new QueryGroupTask warning in 2.18

[doug-numetric]

Describe the bug

The warning:
https://github.com/opensearch-project/OpenSearch/pull/14708/files#diff-4e901163f39dfc072ae4d7f93a43f0958bdfdf2bb82f044b2ec9f3ae13fa66dfR56
Ideally should never happen, but it's spamming our logs for our use cases.

Related component

Search

To Reproduce

curl -s -X POST "localhost:9200/some_index_name/_search?size=2&scroll=30s" -H "content-type: application/json" -d '{"query":{"match_all":{}}}'

with the _scroll_id from the response:

curl -s "localhost:9200/_search/scroll/${_scroll_id}?scroll=30s

The opensearch logs show:

2024-12-17T17:00:36.571341698Z [2024-12-17T17:00:36,570][WARN ][o.o.w.QueryGroupTask     ] [b6feeca76aab] QueryGroup _id can't be null, It should be set before accessing it. This is abnormal behaviour

Expected behavior

No warning

Additional Details

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

• OS: [e.g. iOS]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

[sandeshkr419]

@jainankitk Do you know someone who would be interested in looking this further?

[kaushalmahi12]

Let me look into it.

[kaushalmahi12]

The diff you are mentioning in the issue is old one. This is fixed in all of the branches as part of this PR: 3b4e11d#diff-4e901163f39dfc072ae4d7f93a43f0958bdfdf2bb82f044b2ec9f3ae13fa66df

The issue was when the header is not set in thread context then it would return null for queryGroupId because the threadContext itself is not null

[andrross]

@kaushalmahi12 The reproduction steps shared by @doug-numetric in this issue work for me. I'm able to generate that log statement on a min distribution install of OpenSearch 2.18.

[kaushalmahi12]

I think the mechanism to set the queryGroupId for scroll action is missing. To mitigate the logging from QueryGroupTask class, we can do the following

curl -XPUT "localhost:9200/_cluster/settings" -H "Content-Type: Application/json" -d '{"persistent" : { "logger.org.opensearch.wlm.QueryGroupTask": "ERROR" }}'