Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade HttpCore5/HttpClient5 to support ExtendedSocketOption in HttpAsyncClient #16757

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Dec 2, 2024

Description

Upgrade the httpcore5 version from 5.2.5 to 5.3, to use the ExtendedSocketOption in highlevelClient.

Related Issues

Resolves #15927

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added Clients Clients within the Core repository such as High level Rest client and low level client enhancement Enhancement or improvement to existing feature or request labels Dec 2, 2024
@kkewwei kkewwei changed the title upgrade httpcore5/httpclient5 to support ExtendedSocketOption in HttpAsyncClient Upgrade HttpCore5/HttpClient5 to support ExtendedSocketOption in HttpAsyncClient Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

❌ Gradle check result for 94747a6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the update_httpcomponents branch from 94747a6 to 3187c52 Compare December 2, 2024 15:14
Copy link
Contributor

github-actions bot commented Dec 2, 2024

❌ Gradle check result for 3187c52: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the update_httpcomponents branch from 3187c52 to 27a474b Compare December 2, 2024 16:56
Copy link
Contributor

github-actions bot commented Dec 2, 2024

❌ Gradle check result for 27a474b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Dec 3, 2024

❌ Gradle check result for 4643c50: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the update_httpcomponents branch from 4643c50 to 1beba95 Compare December 3, 2024 14:38
Copy link
Contributor

github-actions bot commented Dec 3, 2024

❌ Gradle check result for 1beba95: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the update_httpcomponents branch from 1beba95 to 71872d7 Compare December 3, 2024 16:21
Copy link
Contributor

github-actions bot commented Dec 3, 2024

❌ Gradle check result for 71872d7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the update_httpcomponents branch from 71872d7 to ad1f65b Compare December 4, 2024 02:36
Copy link
Contributor

github-actions bot commented Dec 4, 2024

❌ Gradle check result for ad1f65b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the update_httpcomponents branch from ad1f65b to f63b0a2 Compare December 4, 2024 18:07
Copy link
Contributor

github-actions bot commented Dec 4, 2024

❌ Gradle check result for f63b0a2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Dec 9, 2024

@kkewwei I think I find out the issue with upgrades, do you mind if I push a few changes into you pull request? thank you

@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 10, 2024

@kkewwei I think I find out the issue with upgrades, do you mind if I push a few changes into you pull request? thank you

@reta Of course, please feel free to continue.

Copy link
Contributor

❌ Gradle check result for c45caf5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the update_httpcomponents branch from c45caf5 to 871b787 Compare December 10, 2024 15:22
Copy link
Contributor

❌ Gradle check result for 871b787: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the update_httpcomponents branch from 871b787 to adff229 Compare December 10, 2024 16:28
Copy link
Contributor

❌ Gradle check result for adff229: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the update_httpcomponents branch from adff229 to 04db61a Compare December 10, 2024 18:44
Copy link
Contributor

❌ Gradle check result for 04db61a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta removed the >breaking Identifies a breaking change. label Dec 17, 2024
@reta reta force-pushed the update_httpcomponents branch from 04db61a to 6bdb182 Compare December 17, 2024 17:52
@reta
Copy link
Collaborator

reta commented Dec 17, 2024

The issue with Reactor Netty and Upgrade flow is fixed and should be available in 1.1.26 release (verified against 1.1.26-SNAPSHOT): reactor/reactor-netty#3538

Copy link
Contributor

❌ Gradle check result for 6bdb182: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clients Clients within the Core repository such as High level Rest client and low level client enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] support ExtendedSocketOption in highlevelClient
3 participants