Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC Search API benchmark #16710

Open
3 tasks
Tracked by #16787
amberzsy opened this issue Nov 23, 2024 · 4 comments
Open
3 tasks
Tracked by #16787

GRPC Search API benchmark #16710

amberzsy opened this issue Nov 23, 2024 · 4 comments
Labels
Meta Meta issue, not directly linked to a PR Search:Performance

Comments

@amberzsy
Copy link

amberzsy commented Nov 23, 2024

Please describe the end goal of this project

based on [Feature] GRPC Document APIs #16784 implementation, perform benchmark on varies query types and search/indexSearch api with different scenarios.

Supporting References

#15190

Issues

  • with [Feature] GRPC Search APIs #16783 PoC implementation, initial benchmark on TermQuery/MatchAllQuery with large payload for request and response.
  • Evaluate/Research and benchmark Search grpc stream api.
  • Benchmark KnnQuery with large dimension and vector sizes.

Related component

Search

@finnegancarroll
Copy link
Contributor

Thanks for creating this issue! Do you think OSB can be leveraged for benchmarking or will a custom solution be needed? I notice both the existing queries and documents in OSB workloads are pretty simplistic so serialization/deserialization of the query itself will be minimal.

@amberzsy amberzsy changed the title [META] GRPC poc and benchmark - [Search] [META] GRPC Search API benchmark Dec 5, 2024
@amberzsy amberzsy changed the title [META] GRPC Search API benchmark GRPC Search API benchmark Dec 5, 2024
@amberzsy
Copy link
Author

amberzsy commented Dec 5, 2024

I notice both the existing queries and documents in OSB workloads are pretty simplistic so serialization/deserialization of the query itself will be minimal.

correct. i think it still have some value to have some basic testing or validation. but to see the real performance gain, will need more complicated/prod-like test case.

Thanks for creating this issue! Do you think OSB can be leveraged for benchmarking or will a custom solution be needed?

for short term, we will do a custom solution which leverage Uber internal benchmark framework and tooling to generate large payload(request and response) with high qps.
for long term, imo, we should add have grpc support in OSB and add more benchmark use cases. which i created issue opensearch-project/opensearch-benchmark#702 for tracking.

@amberzsy
Copy link
Author

amberzsy commented Dec 9, 2024

assigned to @amberzsy

@dblock
Copy link
Member

dblock commented Dec 16, 2024

[Catch All Triage - 1, 2, 3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta Meta issue, not directly linked to a PR Search:Performance
Projects
Status: New
Status: Todo
Development

No branches or pull requests

3 participants