Removed unneeded calls of String.format()

[dk2k]

Removed unneeded calls of String.format()

[github-actions]

❌ Gradle check result for 8ca0e7b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 8ca0e7b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[dblock]

Looks like a legit failure.

* What went wrong:
Execution failed for task ':server:spotlessJavaCheck'.
> The following files had format violations:
      src/main/java/org/opensearch/index/compositeindex/CompositeIndexValidator.java
          @@ -13,8 +13,6 @@
           import·org.opensearch.index.compositeindex.datacube.startree.StarTreeValidator;
           import·org.opensearch.index.mapper.MapperService;
           
          -import·java.util.Locale;
          -
           /**
           ·*·Validation·for·composite·indices·as·part·of·mappings
           ·*
  Run './gradlew :server:spotlessApply' to fix these violations.

[dk2k]

Guys, sorry, rebase didn't go smoothly. I will close this PR and create a new one.
I really think you need to adjust the processes in this repo and make it contributor-friendly. Currently it's a pain in the neck.

[github-actions]

❌ Gradle check result for 351d3a3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[sandeshkr419]

@dk2k Yeah, rebasing has been a major pain. Do you have any suggestions that we can look into?

Also, here is the usual process I do to rebasing smoothly:

1. git remote set-url origin https://github.com/opensearch-project/Opensearch.git
2. git checkout main
3. git pull
4. git checkout
5. git rebase main
6. git remote set-url origin
7. git push origin

Probably I can include these steps in development guide itself.

[dbwiddis]

@dk2k Yeah, rebasing has been a major pain. Do you have any suggestions that we can look into?

I'm not dk2k, but on other repos I maintain there is a GitHub setting that enables rebasing from the PR itself.

It creates this dialog:

[dbwiddis]

@dk2k i messed up my first GitHub PR and had to close and resubmit. You're in good company. :)