Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Concurrent search support with Derived Fields #15007

Closed
mch2 opened this issue Jul 29, 2024 · 1 comment · Fixed by #15326
Closed

[Feature Request] Concurrent search support with Derived Fields #15007

mch2 opened this issue Jul 29, 2024 · 1 comment · Fixed by #15326
Assignees
@mch2
Labels
enhancement Enhancement or improvement to existing feature or request Search:Query Capabilities v2.17.0

Comments

@mch2
Copy link
Member

mch2 commented Jul 29, 2024

Is your feature request related to a problem? Please describe

Today it is documented that Derived Fields are not supported with concurrent segment search. While documented there is nothing preventing a user executing concurrent search code paths while using derived field queries or aggs.

Describe the solution you'd like

Add compatibility, silently ignore concurrent search paths, or at a minimum throw an error.

Related component

Search:Query Capabilities

Describe alternatives you've considered

Do nothing...

Additional context

From - #14618 (comment)
@mch2 mch2 added enhancement Enhancement or improvement to existing feature or request untriaged labels Jul 29, 2024
@mch2 mch2 mentioned this issue Jul 29, 2024
Merged
3 tasks
@jed326 jed326 mentioned this issue Aug 1, 2024
Merged
2 tasks
@jed326
Copy link
Collaborator

jed326 commented Aug 2, 2024

Added SimplePainlessIT#testSimpleDerivedFieldsQuery and SimplePainlessIT#testSimpleDerivedFieldsAgg in #15072 with concurrent search path muted to help debug.

@jed326 jed326 added the v2.17.0 label Aug 19, 2024
@getsaurabh02 getsaurabh02 moved this from Todo to In-Review in Performance Roadmap Aug 19, 2024
@getsaurabh02 getsaurabh02 moved this from Now (This Quarter) to In Progress in Performance Roadmap Aug 19, 2024
@mch2 mch2 mentioned this issue Aug 20, 2024
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Search Project Board Aug 27, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Performance Roadmap Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mch2 mch2

Labels
enhancement Enhancement or improvement to existing feature or request Search:Query Capabilities v2.17.0
Projects
Performance Roadmap
Status: Done
Search Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix DerivedFieldQuery to support concurrent search. mch2/OpenSearch
3 participants
@mch2 @getsaurabh02 @jed326