Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] [Telemetry] Make available the instance of tracer and metrics registry to all the plugins #13635

Closed
Gaganjuneja opened this issue May 13, 2024 · 1 comment · Fixed by #13636
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Other Telemetry:Metrics PRs or issues specific to telemetry metrics framework Telemetry:Tracing PRs or issues specific to telemetry tracing framework v2.15.0 Issues and PRs related to version 2.15.0 v3.0.0 Issues and PRs related to version 3.0.0

Comments

@Gaganjuneja
Copy link
Contributor

Gaganjuneja commented May 13, 2024

Is your feature request related to a problem? Please describe

We want to extend the support of telemetry in the plugins so that plugin code can also be instrumented. We are working on an issue to migrate the metrics from Performance analyzer to the telemetry framework. In order to achieve that we need to inject the telemetry objects to the plugins.

Describe the solution you'd like

We should add a method in the plugin interface which helps in injecting the telemetry instances to all the plugins and plugin can overrirde that method and use. Instead of injecting the multiple instances we should have a one single Telemetry object which should be able to give access to specific objects like tracer and metricsRegistry.

Related component

Other

Describe alternatives you've considered

No response

Additional context

No response

@Gaganjuneja Gaganjuneja added enhancement Enhancement or improvement to existing feature or request untriaged Telemetry:Tracing PRs or issues specific to telemetry tracing framework Telemetry:Metrics PRs or issues specific to telemetry metrics framework labels May 13, 2024
@Gaganjuneja Gaganjuneja self-assigned this May 13, 2024
@github-actions github-actions bot added the Other label May 13, 2024
@peternied
Copy link
Member

[Triage - attendees 1 2 3 4 5 6 7 8]
@Gaganjuneja Thanks for creating this issue and pull request for this functionality

@reta reta added v3.0.0 Issues and PRs related to version 3.0.0 v2.15.0 Issues and PRs related to version 2.15.0 labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Other Telemetry:Metrics PRs or issues specific to telemetry metrics framework Telemetry:Tracing PRs or issues specific to telemetry tracing framework v2.15.0 Issues and PRs related to version 2.15.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants