Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Upload remote index path for migrating indexes from docrep to remote #13302

Closed
ashking94 opened this issue Apr 19, 2024 · 0 comments · Fixed by #13386
Closed
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Remote v2.14.0

Comments

@ashking94
Copy link
Member

Is your feature request related to a problem? Please describe

We have introduced a new hash prefix strategy for remote store in #12567. With the new prefix strategy, we also need to upload the index paths. For new indexes, we have a running PR - #13150. However, based on my current understanding, for migration, this would not work since the current hook is only for new indexes.

Describe the solution you'd like

The hook that is beforeNewIndexUpload in IndexMetadataUploadListener needs to be updated or changed to a model where we would have the list of index metadata that needs to be updated along with their previous state of index metadata. We can then change the logic where it checks that the remoteCustomData is not present in previous state and present now. In such cases, we can upload the index path.

Related component

Storage:Remote

Describe alternatives you've considered

NA

Additional context

NA

@ashking94 ashking94 added enhancement Enhancement or improvement to existing feature or request untriaged and removed untriaged labels Apr 19, 2024
@ashking94 ashking94 self-assigned this Apr 19, 2024
@ashking94 ashking94 moved this from 🆕 New to Ready To Be Picked in Storage Project Board Apr 19, 2024
@github-project-automation github-project-automation bot moved this to Planned work items in Test roadmap format Apr 19, 2024
@ashking94 ashking94 moved this from Ready To Be Picked to 🏗 In progress in Storage Project Board Apr 26, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Storage Project Board Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Remote v2.14.0
Projects
Status: ✅ Done
Status: Planned work items
Development

Successfully merging a pull request may close this issue.

1 participant