Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote Store] Prevent version upgrade during MIXED compatibility mode #13250

Closed
ltaragi opened this issue Apr 17, 2024 · 1 comment · Fixed by #13185
Closed

[Remote Store] Prevent version upgrade during MIXED compatibility mode #13250

ltaragi opened this issue Apr 17, 2024 · 1 comment · Fixed by #13185
Assignees
@ltaragi
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework Storage:Remote

Comments

@ltaragi
Copy link
Contributor

ltaragi commented Apr 17, 2024

Is your feature request related to a problem? Please describe

  • During migration, primary shards always move first, while during version changes, replica shards move first.
  • Thus, in MIXED compatibility mode, as new nodes join the cluster, nodes with a different version should not be allowed to join.

Describe the solution you'd like

  • A check for this can be added in JoinTaskExecutor.java, where the compatibility of the joining node with the cluster is verified inside ensureRemoteStoreNodesCompatibility.

Related component

Storage:Remote

Describe alternatives you've considered

No response

Additional context

No response
@ltaragi ltaragi added enhancement Enhancement or improvement to existing feature or request untriaged Storage:Durability Issues and PRs related to the durability framework Storage:Remote labels Apr 17, 2024
@ltaragi ltaragi self-assigned this Apr 17, 2024
@ltaragi ltaragi mentioned this issue Apr 17, 2024
Merged
8 tasks
@peternied
Copy link
Member

[Triage - attendees 1 2 3 4 5 6 7]
@ltaragi Thanks for filing this issue, and creating the draft PR to address

@reta reta mentioned this issue Apr 17, 2024
Closed
@ltaragi ltaragi moved this from 🆕 New to 👀 In review in Storage Project Board Apr 18, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Storage Project Board Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ltaragi ltaragi

Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework Storage:Remote
Projects
Storage Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent version upgrade during MIXED compatibility mode ltaragi/OpenSearch
2 participants
@peternied @ltaragi