Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote State] Upload each metadata attributes file instead of single global metadata file #12468

Closed
shiv0408 opened this issue Feb 26, 2024 · 4 comments · Fixed by #12190
Closed
Assignees
Labels
Cluster Manager enhancement Enhancement or improvement to existing feature or request

Comments

@shiv0408
Copy link
Member

shiv0408 commented Feb 26, 2024

Is your feature request related to a problem? Please describe

Currently, we are storing our remote cluster state in a global metadata file and index metadata files for each index and maintain all the info in manifest file. As the cluster grows and cluster state size grows with more usage, the global metadata size also increases.
Whenever we trigger a cluster state update, we need to write the updated metadata on remote. If the global metadata file size has increased and the incoming change is also in global metadata file, we will upload the whole file again, for a small change of settings as well, thus increasing the cluster state update latency.

Describe the solution you'd like

We propose that we split the global metadata file into following following components:

global-metadata/
       | --> coordination__metadata
       | --> settings__metadata
       | --> templates__metadata
       | --> custom__<type1>__metadata
       | --> custom__<type2>__metadata 
.
.

This way if only a setting is modified, we don't update other files. If multiple files need to updated, those are updated in parallel, which is again better than upload full file.
This change will help in majorly decreasing cluster state update latency in big clusters.

Related component

Cluster Manager

Describe alternatives you've considered

No response

Additional context

No response

@peternied
Copy link
Member

[Triage - attendees 1 2 3 4 5]
@shiv0408 Thanks for creating this issue; however, it isn't being accepted due to its not being clear what the problem is or how this is addressed. Please feel free to open a new issue after addressing the reason.

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Cluster Manager Project Board Feb 28, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in Cluster Manager Project Board Mar 13, 2024
@sarthakaggarwal97
Copy link
Contributor

@shiv0408 thanks for elaborating on the issue. Please share some numbers of improvement as well. thanks!

@shiv0408
Copy link
Member Author

Thanks for reopening the issue @sarthakaggarwal97. I have added the benchmark results in linked PR.

We see around 50-70% improvement in writing Incremental Metadata, see PR #12190 for more details.

@andrross
Copy link
Member

[Triage - attendees 1 2 3]
@shiv0408 Thanks for filing this issue. Looking forward to seeing progress here.

@shiv0408 shiv0408 moved this from 🏗 In progress to 👀 In review in Cluster Manager Project Board Mar 13, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cluster Manager Project Board May 16, 2024
@shiv0408 shiv0408 self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cluster Manager enhancement Enhancement or improvement to existing feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants