Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic duplication in SearchRequestContext and TimeProvider #11762

Closed
ansjcy opened this issue Jan 5, 2024 · 1 comment
Closed

Logic duplication in SearchRequestContext and TimeProvider #11762

ansjcy opened this issue Jan 5, 2024 · 1 comment
Assignees
Labels
Search:Query Insights Search Search query, autocomplete ...etc

Comments

@ansjcy
Copy link
Member

ansjcy commented Jan 5, 2024

Describe the bug

SearchRequestContext and TimeProvider both has Phase Took Map, and they are basically recording the same thing. We can investigate if we can improve these logic to make them simpler. Also, we should seek ways to make the workflow to add a SearchOperationsListener easier so that plugins outside of core can also utilize it to create their own listeners.

Related component

Search:Query Insights

To Reproduce

Check the logic in

They are updated with the same data.

Expected behavior

Remove this duplication by refactoring the code to improve the maintainability and simplicity of the core search path.

Additional Details

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@ansjcy ansjcy added bug Something isn't working untriaged labels Jan 5, 2024
@ansjcy ansjcy self-assigned this Jan 5, 2024
@ansjcy ansjcy added Search Search query, autocomplete ...etc and removed bug Something isn't working labels Jan 5, 2024
@ansjcy ansjcy moved this from Todo to In Progress in Performance Roadmap Jan 5, 2024
@msfroh msfroh removed the untriaged label Jan 10, 2024
@ansjcy ansjcy closed this as completed Jan 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Performance Roadmap Jan 11, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Search Project Board Jan 11, 2024
@ansjcy
Copy link
Member Author

ansjcy commented Jan 11, 2024

Closing this issue with resolution in #11526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Search:Query Insights Search Search query, autocomplete ...etc
Projects
Status: Done
Archived in project
Development

No branches or pull requests

2 participants