Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix left over termQuery in Keyword fields to be searchable with doc_values #11538

Closed
harshavamsi opened this issue Dec 8, 2023 · 3 comments
Closed
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc v2.12.0 Issues and PRs related to version 2.12.0

Comments

@harshavamsi
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Coming from #7057, there is a left over termQuery that needs to be searchable when only doc_values are enabled.

Describe the solution you'd like
Similar to the work done for term queries in #11209, override term query and then handle all three cases when index and doc_values are enabled/disabled.

Describe alternatives you've considered
Do nothing.

@harshavamsi harshavamsi added enhancement Enhancement or improvement to existing feature or request untriaged labels Dec 8, 2023
@harshavamsi harshavamsi self-assigned this Dec 8, 2023
@harshavamsi harshavamsi added the v2.12.0 Issues and PRs related to version 2.12.0 label Dec 8, 2023
@getsaurabh02 getsaurabh02 moved this from Todo to Now (This Quarter) in Performance Roadmap Dec 8, 2023
@ankitkala ankitkala added Search Search query, autocomplete ...etc and removed Other labels Dec 15, 2023
@macohen macohen removed the untriaged label Dec 20, 2023
@getsaurabh02 getsaurabh02 moved this from Now (This Quarter) to In Progress in Performance Roadmap Dec 20, 2023
@getsaurabh02 getsaurabh02 moved this from In Progress to Done in Performance Roadmap Jan 17, 2024
@kiranprakash154
Copy link
Contributor

Hi, are we on track for this to be released in 2.12 ?

@harshavamsi
Copy link
Contributor Author

Hi @kiranprakash154 we determined that this is something that we don't see making any impact, so we scrapped this.

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Search Project Board Jan 19, 2024
@msfroh
Copy link
Collaborator

msfroh commented Jan 19, 2024

@harshavamsi -- Does it make sense to still handle the DV-only case? That is, skip the IndexOrDocValuesQuery case (using the indexed query whenever we can).

That is, we wouldn't want to do this as a performance optimization, but we could handle term queries on a non-indexed keyword field that has doc values. I'm imagining a case where there's a kw field that (almost) never gets queried, but does get aggregated over, so we just have doc values. If you do want to query it rarely (or at least filter on it), you could do that as a DV lookup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc v2.12.0 Issues and PRs related to version 2.12.0
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants