Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top N queries by Latency - aggregator implementation #11295

Closed
ansjcy opened this issue Nov 21, 2023 · 1 comment
Closed

Top N queries by Latency - aggregator implementation #11295

ansjcy opened this issue Nov 21, 2023 · 1 comment
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Search:Query Insights untriaged v2.12.0 Issues and PRs related to version 2.12.0

Comments

@ansjcy
Copy link
Member

ansjcy commented Nov 21, 2023

Is your feature request related to a problem? Please describe.
Currently, OpenSearch lacks a direct means of providing insights into “top queries” that have a significant impact on latency, we want to build the in-memory aggregator to capture those queries on the coordinator node level.
(Parent rfc: #11186)

Describe the solution you'd like
Implement a priority queue-based in-memory data store, with configurable window size, on the coordinator node, designed to efficiently store the top N queries. The data model of the stored query attributes should be highly extensible for different types of resources and metrics.

Describe alternatives you've considered
We can instead export the data and offload the query instrumentation logic to external sinks. But it would require us to retain all necessary data for every request. Additionally, as of now we lack a state-of-the-art on-node store capable of holding all request information for aggregation and calculating the top N when user requested. Moreover, we refrain from introducing dependencies on a specific sink in this feature.

Additional context
Please see parent rfc: #11186

@ansjcy ansjcy added enhancement Enhancement or improvement to existing feature or request untriaged labels Nov 21, 2023
@ansjcy ansjcy moved this to Now (This Quarter) in Performance Roadmap Nov 21, 2023
@ansjcy ansjcy moved this from Now (This Quarter) to In Progress in Performance Roadmap Nov 21, 2023
@ansjcy ansjcy self-assigned this Nov 21, 2023
@getsaurabh02 getsaurabh02 moved this from In Progress to In-Review in Performance Roadmap Dec 15, 2023
@getsaurabh02 getsaurabh02 added the v2.12.0 Issues and PRs related to version 2.12.0 label Jan 22, 2024
@ansjcy ansjcy moved this from In-Review to Now (This Quarter) in Performance Roadmap Jan 23, 2024
@ansjcy
Copy link
Member Author

ansjcy commented Feb 6, 2024

This is done by #11903

@ansjcy ansjcy closed this as completed Feb 6, 2024
@github-project-automation github-project-automation bot moved this from Now (This Quarter) to Done in Performance Roadmap Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Query Insights untriaged v2.12.0 Issues and PRs related to version 2.12.0
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants