Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a backoff time field to _bulk requests response #11289

Open
priyatsh opened this issue Nov 21, 2023 · 2 comments
Open

Add a backoff time field to _bulk requests response #11289

priyatsh opened this issue Nov 21, 2023 · 2 comments
Labels
enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing

Comments

@priyatsh
Copy link

Is your feature request related to a problem? Please describe.
In some of the tests for ingestion, we want to re-trigger bulk requests for some re-triable errors with a backoff(based on the failure). In order to retry bulk requests with backoff time, we need additional field backoff time in the response from the server so that the client can re-trigger the bulk request in case of a re-triable error after the appropriate backoff time.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@priyatsh priyatsh added enhancement Enhancement or improvement to existing feature or request untriaged labels Nov 21, 2023
@dhwanilpatel dhwanilpatel added the Indexing Indexing, Bulk Indexing and anything related to indexing label Nov 24, 2023
@dhwanilpatel
Copy link
Contributor

Ideally client should decide the backoff time based on retry strategy, client may need to retry with fix delay/exponential delay/other strategy.

Can you please share more details on why it needs to be returned from server?

@dblock
Copy link
Member

dblock commented Nov 26, 2023

This is a nice to have feature if the server knows for sure that retrying an API will fail in the next N time. It's pretty common for systems that do rate limiting, but it's not as common in systems that have load-based circuit breakers. Does OpenSearch have useful information for the client about when it's best to retry a bulk operation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing
Projects
None yet
Development

No branches or pull requests

4 participants